New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow-cpp: disable zstd #48833
arrow-cpp: disable zstd #48833
Conversation
"compression-test" fails when built against zstd 1.3.6 Fixes: c8f7188 ('zstd: 1.3.5 -> 1.3.6 (NixOS#47965)') Fixes: NixOS#47965
@GrahamcOfBorg build arrow-cpp |
Failure on aarch64-linux (full log) Attempted: arrow-cpp Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: arrow-cpp Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-darwin (full log) Attempted: arrow-cpp Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: arrow-cpp Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: arrow-cpp Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: arrow-cpp Partial log (click to expand)
|
I seems one has to patch/configure arrow-cpp to not download zstd itself:
|
@Mic92 I'm sorry for the noise and wasting your time. It doesn't seem like I can really disable zstd and keep the tests for arrow-cpp. I've opened the issue with upstream at facebook/zstd#1385 . |
No worries. |
"compression-test" fails when built against zstd 1.3.6
Fixes: c8f7188 ('zstd: 1.3.5 -> 1.3.6 (#47965)')
Fixes: #47965
Motivation for this change
arrow-cpp was broken by zstd upgrade from 1.3.5 to 1.3.6. I don't have time to fix this myself. I also have impression that upstream would not care about this.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)