Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ddclient: make RuntimeDirectory and configFile private #48844

Merged
merged 2 commits into from Oct 26, 2018
Merged

nixos/ddclient: make RuntimeDirectory and configFile private #48844

merged 2 commits into from Oct 26, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 22, 2018

Motivation for this change

Resolves #48433
ddclient will raise a warning if /run/ddclient/ is world-readable

cc @bjornfor for testing (I haven't tested TBH)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
nixos/ddclient: make RuntimeDirectory private
f76a9eb 
ddclient will raise a warning if /run/ddclient/ is world-readable
@c0bw3b
nixos/ddclient: make configFile private
ab5380e 
/run/ddclient/ddclient.conf should be installed in mode 660 (readable and writeable only by ddclient.service user and group)
@peterhoeg
Copy link
Member

I haven't tested it but looks good to me.

@c0bw3b c0bw3b changed the title nixos/ddclient: make RuntimeDirectory private nixos/ddclient: make RuntimeDirectory and configFile private Oct 23, 2018
@infinisil infinisil merged commit f374add into NixOS:master Oct 26, 2018
@c0bw3b c0bw3b deleted the svc/ddclient branch October 27, 2018 07:03
@womfoo womfoo mentioned this pull request Dec 29, 2018
Closed
@infinisil infinisil mentioned this pull request Dec 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0bw3b @peterhoeg @infinisil @GrahamcOfBorg