Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: change markup of master branch #48854

Closed
wants to merge 1 commit into from
Closed

README.md: change markup of master branch #48854

wants to merge 1 commit into from

Conversation

gityash01
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

I expect the branch_name formatting for the branch name is very much intentional (and is conventional from what I've seen elsewhere). I wonder how a quoted name is better?

Mic92
Mic92 reviewed Oct 23, 2018
View reviewed changes
README.md
@@ -20,7 +20,7 @@ release and `nixos-unstable` for the latest successful build of master:
% git rebase channels/nixos-18.09
```

For pull-requests, please rebase onto nixpkgs `master`.
For pull-requests, please rebase onto nixpkgs "master" .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I prefer the old version.

@Mic92 Mic92 changed the title Update README.md README.md: change markup of master branch Oct 23, 2018
@lheckemann
Copy link
Member

Marked as invalid:

  • Agreement to licence not given (clearly hasn't read the contribution guidelines or the PR template, not even bothered to tick the boxes)
  • Not a useful change

I'd judge this Hacktoberfest spam.

@lheckemann lheckemann closed this Oct 23, 2018
@infinisil infinisil mentioned this pull request Oct 23, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
2.status: invalid 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gityash01 @joachifm @lheckemann @Mic92 @GrahamcOfBorg @Janik-Haag