Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sphinx: 1.7.9 -> 1.8.2 #48841

Closed
wants to merge 1 commit into from
Closed

pythonPackages.sphinx: 1.7.9 -> 1.8.2 #48841

wants to merge 1 commit into from

Conversation

timokau
Copy link
Member

@timokau timokau commented Oct 22, 2018

Motivation for this change

A new sphinx release is out, sage needs patching.

@FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner October 22, 2018 21:23
@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg build python27Packages.sphinx python36Packages.sphinx

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.sphinx, python36Packages.sphinx

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1/lib  /nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1/bin
patching script interpreter paths in /nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1
checking for references to /build in /nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1...
wrapping `/nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1/bin/sphinx-autogen'...
wrapping `/nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1/bin/sphinx-quickstart'...
wrapping `/nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1/bin/sphinx-build'...
wrapping `/nix/store/7h92ldvpi371rmhis3c47gp3n0d1ggfa-python2.7-Sphinx-1.8.1/bin/sphinx-apidoc'...
error: build of '/nix/store/02mlqg9553bj8byhwnjsc1j83chddr8z-python3.6-Sphinx-1.8.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python27Packages.sphinx, python36Packages.sphinx

Partial log (click to expand)

cannot build derivation '/nix/store/i6sbfswm19h6wvyyl41jamrl1cysmvf2-python3.6-html5lib-1.0.1.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/96ya78dfkn54q9g4ya7n3fy7gmbr0w9p-python3.6-hypothesis-3.66.2.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/qznpfb8hvzrwxypiqhza886rf5rq388c-python2.7-Sphinx-1.8.1.drv': 25 dependencies couldn't be built
cannot build derivation '/nix/store/5k63r6mmxz2xixdh4z8cqaskbaxnrncb-python3.6-chardet-3.0.4.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/bdk8y1vdj65cicyy02s2lll54as6fbyk-python3.6-cryptography-2.3.1.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/8j00vv1dgf5fr9asj9g9p6zqg107796n-python3.6-pyOpenSSL-18.0.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/3k509vpzh6a33lh79har285rxsaf7a4b-python3.6-urllib3-1.23.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/va0wc8pry32ib5bhjjypbxf1d6kscwi1-python3.6-requests-2.19.1.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/byfjk01ggdr6i3gsh7pd77gfr9bz93xc-python3.6-Sphinx-1.8.1.drv': 23 dependencies couldn't be built
error: build of '/nix/store/byfjk01ggdr6i3gsh7pd77gfr9bz93xc-python3.6-Sphinx-1.8.1.drv', '/nix/store/qznpfb8hvzrwxypiqhza886rf5rq388c-python2.7-Sphinx-1.8.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python27Packages.sphinx, python36Packages.sphinx

Partial log (click to expand)

cannot build derivation '/nix/store/7fnlw0nvkjdb0pyxv83wgm7kdcd1km05-python3.6-Sphinx-1.8.1.drv': 1 dependencies couldn't be built
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1/lib  /nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1/bin
patching script interpreter paths in /nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1
checking for references to /build in /nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1...
wrapping `/nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1/bin/sphinx-build'...
wrapping `/nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1/bin/sphinx-autogen'...
wrapping `/nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1/bin/sphinx-apidoc'...
wrapping `/nix/store/f6fdq9rjpdkjg8a0vvr0877xfcplp4vq-python2.7-Sphinx-1.8.1/bin/sphinx-quickstart'...
error: build of '/nix/store/7fnlw0nvkjdb0pyxv83wgm7kdcd1km05-python3.6-Sphinx-1.8.1.drv' failed

@timokau
Copy link
Member Author

timokau commented Oct 23, 2018

The python3 build fails because the dependency pycodestyle fails. That bisecting puts the cause of that at the upgrade from python 3.6.6 to python 3.6.7 (241bab3).

@FRidh FRidh self-assigned this Oct 24, 2018
@timokau
Copy link
Member Author

timokau commented Nov 10, 2018

Rebased, python3 issue still present.

@timokau
Copy link
Member Author

timokau commented Nov 10, 2018

Fails due to python3.7-simplejson now though.

@timokau timokau changed the title sphinx: 1.7.9 -> 1.8.1 [WIP] sphinx: 1.7.9 -> 1.8.2 Nov 11, 2018
@timokau timokau changed the title [WIP] sphinx: 1.7.9 -> 1.8.2 [WIP] pythonPackages.sphinx: 1.7.9 -> 1.8.2 Nov 11, 2018
@timokau
Copy link
Member Author

timokau commented Nov 11, 2018

@FRidh bisecting shows that c1e003f (reduce amount of warnings when building with buildPhyton) broke the cython build. They test some verbose output. Example failures:

----------------------------------------------------------------------
File "/build/Cython-0.29/TEST_TMP/0/run/c/cdivision_CEP_516/cdivision_CEP_516.so", line ?, in cdivision_CEP_516.__test__.complex_ex>
Failed example:
    complex_expression(-150, 20, 19, -7)
Expected:
    verbose_call(20)
    division with oppositely signed operands, C and Python semantics differ
    verbose_call(19)
    division with oppositely signed operands, C and Python semantics differ
    -2
Got:
    verbose_call(20)
    division with oppositely signed operands, C and Python semantics differ
    verbose_call(19)
    -2

Failed example:
    div_int_c_warn(-17, 10)
Expected:
    division with oppositely signed operands, C and Python semantics differ
    -1
Got:
    -1

timokau referenced this pull request Nov 11, 2018
@FRidh
Python: reduce amount of warnings when building with buildPython*
c1e003f 
By default all warnings were printed. This occasionally resulted in
a lot of warnings leading to builds being killed.

This commit reduces the amount of warnings printed.
@timokau
Copy link
Member Author

timokau commented Nov 13, 2018

Okay should be good to go now. python3 build is still failing because the cython dependency fails on python3. That is because I messed up the cython upgrade. Didn't test it on python3 where it now needs the pycodestyle dependency for tests. I'll fix that in a separate PR.

@Synthetica9 I had to switch the pname to capital instead, which you changed recently. That is because pypi lists it with the capital name. Why did you change it initially?

@timokau timokau changed the title [WIP] pythonPackages.sphinx: 1.7.9 -> 1.8.2 pythonPackages.sphinx: 1.7.9 -> 1.8.2 Nov 13, 2018
@timokau
Copy link
Member Author

timokau commented Nov 25, 2018

Rebased. @FRidh (I still don't know what the policy for non-trivial python package changes is)

@timokau
Copy link
Member Author

timokau commented Dec 31, 2018

Rebased again. Ping @FRidh

@bgamari
Copy link
Contributor

bgamari commented Jan 16, 2019

@FRidh, indeed it would be great to have this upstream.

@FRidh
Copy link
Member

FRidh commented Jan 17, 2019

This got hidden in the long pile of review requests/mentions. I added a Sphinx update in #54186.

@timokau timokau closed this Feb 2, 2019
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 2, 2019
@timokau
sage: add compatibility for sphinx 1.8.3
2f49da3 
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.
@timokau timokau mentioned this pull request Feb 2, 2019
Merged
10 tasks
@timokau timokau deleted the sphinx-1.8.1 branch February 2, 2019 10:33
timokau added a commit that referenced this pull request Feb 2, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (#55078)
33db01e 
Since #48841 was replaced by
#54186, this needs to be done
separately.
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (NixOS#55078)
fd1079f 
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (NixOS#55078)
3942e00 
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
timokau added a commit that referenced this pull request Feb 11, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (#55078) (#55560)
342333c 
Since #48841 was replaced by
#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timokau @xeji @GrahamcOfBorg @bgamari @FRidh