perlPackages.ClusterSSH: init at 4.13.2 #48857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right, thanks! I've been looking at CPAN before, but I thought it's just some library and not the program itself. I've also added installation of script for bash completion and missing dependency on openssh. |
|
@GrahamcOfBorg build perlPackages.ClusterSSH @aither64 Doing a quick scan of the perl source code I found this: https://metacpan.org/source/DUNCS/App-ClusterSSH-v4.13.2/lib/App/ClusterSSH/Config.pm#L464 Without looking into it in detail, did you test the application in such a way that you confirmed this code works as intended? |
|
Success on x86_64-linux (full log) Attempted: perlPackages.ClusterSSH Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: perlPackages.ClusterSSH Partial log (click to expand)
|
Mic92
reviewed
Nov 15, 2018
Mic92
reviewed
Nov 15, 2018
pkgs/top-level/perl-packages.nix
Outdated
| sha256 = "0rmk2p3f2wz1h092anidjclh212rv3gxyk0c641qk3frlrjnw6mp"; | ||
| }; | ||
| propagatedBuildInputs = [ ExceptionClass FilePath GetoptLong LocaleMaketext Tk TryTiny X11Protocol X11ProtocolOther pkgs.coreutils pkgs.openssh pkgs.xterm ]; | ||
| buildInputs = [ FileSlurp FileTemp FileWhich CPANChanges TestPerlTidy TestPod TestPodCoverage Readonly TestDifferences TestDistManifest TestTrap ]; |
There was a problem hiding this comment.
Please break both lists into multiple lines for readability.
|
@aanderse, yes, I'm using it and it works for me. The code you linked is used to find xterm (or some other configured terminal), so the hardcoded paths would be used if it weren't found already in |
aither64
force-pushed
the
clusterssh
branch
2 times, most recently
from
f7432b1
to
a2c3af4
Compare
|
@GrahamcOfBorg build perlPackages.ClusterSSH |
|
Success on x86_64-linux (full log) Attempted: perlPackages.ClusterSSH Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: perlPackages.ClusterSSH Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: perlPackages.ClusterSSH Partial log (click to expand)
|
Makes sense to me. In this situation you should avoid adding /run/current-system/sw/bin as it is always better to explicitly declare dependencies when you can, like this situation. Looking good. |
|
@GrahamcOfBorg build perldevelPackages.ClusterSSH |
|
@volth do we need to take special care if packages do not build for specific perl version? |
|
Failure on x86_64-linux (full log) Attempted: perldevelPackages.ClusterSSH Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: perldevelPackages.ClusterSSH Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: perldevelPackages.ClusterSSH Partial log (click to expand)
|
|
@GrahamcOfBorg build perlPackages.ClusterSSH |
|
@GrahamcOfBorg build perldevelPackages.ClusterSSH |
|
Sorry for the delay. I've rebased it on nixos-unstable, added |
|
This is obsoleted by #65043 and should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds ClusterSSH with one dependency and myself as a maintainer. ClusterSSH is a tool that lets you interactively manage multiple servers over SSH at once.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)