New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update android sdk, add license config option and selectable build tools #48848
Conversation
Do you have an example project I could use to test this? |
7c86095
to
8447d64
Compare
That's a great idea, I'll try to find one or set one up. |
0e70328
to
fbf0d79
Compare
5da7ccb
to
c954ae0
Compare
It's deprecated, and no longer prints the urls of any xml files for the script to parse.
Manually corrected three problems: - fetch.sh: android cli cannot find java executable - addons.nix: google_apis_25 expression not added correctly - addons.nix: android_support_extra expression deleted (replaced in android 9 with jetpack/androidx)
c954ae0
to
413733f
Compare
413733f
to
d861da1
Compare
@Mic92 I made these changes to create expo/expo#2506; you could use that PR's branch as a test. After checking it out, you can look at I've also been able to get owncloud/android building with this shell.nix:
...and the command |
I had to set ANDROID_HOME instead of ANDROID_SDK_ROOT, but it worked out in the end: with import <nixpkgs> {
config = {
allowUnfree = true;
android_sdk.accept_license = true;
};
};
let
sdk = androidenv.androidsdk {
platformVersions = [ "26" ];
buildToolsVersions = [ "27.0.3" ];
abiVersions = [ "x86" "x86_64"];
useGoogleAPIs = true;
};
in mkShell {
LANG="en_US.UTF-8";
ANDROID_HOME="${sdk}/libexec";
nativeBuildInputs = [
glibcLocales
nodejs-8_x
openjdk8
sdk
];
} I wonder if we should add this an example like this into nixpkgs or in the wiki? |
this seems to work but the command
can you have a look at that? @nicknovitski |
@myguidingstar Good catch, thank you. #49564 |
@Mic92 The android infrastructure could definitely benefit from a section in the manual. |
@nicknovitski I invite you to do that. If docbook is not your thing there is also markdown supported. (see python.md) |
@nicknovitski @Mic92 this pull request also breaks |
if I run
It also says |
I also got this error when trying to run
|
@myguidingstar this will be fixed with: #49515 |
@Mic92 actually I've picked that patch, and the above warnings and errors are made with that branch |
Ah right. Did not pay enough attention. |
Hi, I am working on a revised implementation of the Android SDK that fixes most of our current problems, and provides several kinds of new facilities that make maintenance a lot easier. More information can be found here: https://discourse.nixos.org/t/my-revised-experimental-android-build-functions/923 My revised implementation lives in a separate repository, but I intend to soon work on a reintegration strategy. |
I followed #36112 and some other license-requiring packages.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)