Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c55fa1e122b3
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b95b7e450168
Choose a head ref
  • 14 commits
  • 11 files changed
  • 7 contributors

Commits on Nov 1, 2018

  1. slack-term: init at 0.4.1

    dtzWill committed Nov 1, 2018
    Copy the full SHA
    81f39ee View commit details

Commits on Nov 4, 2018

  1. coq_8_9: init at 8.9+beta1

    Zimmi48 authored and vbgl committed Nov 4, 2018
    Copy the full SHA
    dd21f83 View commit details
  2. radeon-crimson: fix download

    davidak authored and FRidh committed Nov 4, 2018
    Copy the full SHA
    6e05256 View commit details
  3. Copy the full SHA
    64d50a0 View commit details
  4. Merge master into staging-next

    FRidh committed Nov 4, 2018
    Copy the full SHA
    cb4ff92 View commit details
  5. Merge pull request #49603 from dtzWill/feature/slack-term

    slack-term: init at 0.4.1
    c0bw3b authored Nov 4, 2018
    Copy the full SHA
    3866910 View commit details
  6. Python: reduce amount of warnings when building with buildPython*

    By default all warnings were printed. This occasionally resulted in
    a lot of warnings leading to builds being killed.
    
    This commit reduces the amount of warnings printed.
    FRidh committed Nov 4, 2018
    11
    Copy the full SHA
    c1e003f View commit details
  7. Copy the full SHA
    5b744f4 View commit details
  8. Revert "Merge pull request #49398 from Synthetica9/implement-rfc0035"…

    … to fix eval
    
    This reverts commit 3fc7d5e, reversing
    changes made to 1fddf2b.
    
    The idea is good, however, before enforcing, make sure all occurences
    are fixed.
    FRidh committed Nov 4, 2018
    Copy the full SHA
    abea6f4 View commit details
  9. openjpeg: adding patch for CVE-2018-7648

    (cherry picked from commit 3dc0838)
    Forward-picking from staging-next.  The CVE is marked as critical,
    and the amount of rebuilds isn't that high (~500 linux, ~100 darwin).
    stammon authored and vcunat committed Nov 4, 2018
    Copy the full SHA
    058a3c0 View commit details
  10. Revert "systemd: 239 -> 239.20181031"

    This reverts commit d1de23b.
    The changes turned out to be too intrusive, so we'll patch instead.
    Discussion: NixOS/systemd#24
    vcunat committed Nov 4, 2018
    Copy the full SHA
    587c377 View commit details
  11. systemd: apply patches from Debian

    There are some security fixes among those.
    vcunat committed Nov 4, 2018
    Copy the full SHA
    179b814 View commit details
  12. Merge master into staging-next

    FRidh committed Nov 4, 2018
    Copy the full SHA
    322f871 View commit details
  13. Copy the full SHA
    b95b7e4 View commit details
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{ stdenv, buildGoPackage, fetchFromGitHub }:

buildGoPackage rec {
# https://github.com/erroneousboat/slack-term
name = "slack-term-${version}";
version = "0.4.1";

goPackagePath = "github.com/erroneousboat/slack-term";

src = fetchFromGitHub {
owner = "erroneousboat";
repo = "slack-term";
rev = "v${version}";
sha256 = "1340bq7h31fxykxbxpn6hv7n2hmjf20f8vg5gan9pjf5jaa6kfza";
};

meta = with stdenv.lib; {
description = "Slack client for your terminal";
homepage = https://github.com/erroneousboat/slack-term;
license = licenses.mit;
maintainers = with maintainers; [ dtzWill ];
};
}
1 change: 1 addition & 0 deletions pkgs/applications/science/logic/coq/default.nix
Original file line number Diff line number Diff line change
@@ -25,6 +25,7 @@ let
"8.8.0" = "13a4fka22hdxsjk11mgjb9ffzplfxyxp1sg5v1c8nk1grxlscgw8";
"8.8.1" = "1hlf58gwazywbmfa48219amid38vqdl94yz21i11b4map6jfwhbk";
"8.8.2" = "1lip3xja924dm6qblisk1bk0x8ai24s5xxqxphbdxj6djglj68fd";
"8.9+beta1" = "1yxv2klqal3mh6symi3gc6gv3xm684zlld2c0b6ijhjmp865cin8";
}."${version}";
coq-version = builtins.substring 0 3 version;
ideFlags = if buildIde then "-lablgtkdir ${ocamlPackages.lablgtk}/lib/ocaml/*/site-lib/lablgtk2 -coqide opt" else "";
4 changes: 4 additions & 0 deletions pkgs/development/interpreters/python/mk-python-derivation.nix
Original file line number Diff line number Diff line change
@@ -101,6 +101,10 @@ toPythonModule (python.stdenv.mkDerivation (builtins.removeAttrs attrs [
${python.interpreter} ${./catch_conflicts}/catch_conflicts.py
'' + attrs.postFixup or '''';

# Print fewer warnings so we have less noise in our logs
# The amount of warnings also caused builds to be terminated.
PYTHONWARNINGS="once";

meta = {
# default to python's platforms
platforms = python.meta.platforms;
2 changes: 1 addition & 1 deletion pkgs/development/python-modules/cffi/default.nix
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ if isPyPy then null else buildPythonPackage rec {

doCheck = !stdenv.hostPlatform.isMusl; # TODO: Investigate
checkPhase = ''
py.test
py.test -k "not test_char_pointer_conversion"
'';

meta = with stdenv.lib; {
3 changes: 2 additions & 1 deletion pkgs/development/python-modules/pytest/default.nix
Original file line number Diff line number Diff line change
@@ -24,7 +24,8 @@ buildPythonPackage rec {

checkPhase = ''
runHook preCheck
$out/bin/py.test -x testing/
# Re-enable warnings because the test suite relies on it.
PYTHONWARNINGS= $out/bin/py.test -x testing/
runHook postCheck
'';

8 changes: 7 additions & 1 deletion pkgs/development/tools/build-managers/meson/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, python3Packages, stdenv, writeTextDir, substituteAll }:
{ lib, python3Packages, stdenv, writeTextDir, substituteAll, fetchpatch }:

python3Packages.buildPythonApplication rec {
version = "0.46.1";
@@ -41,6 +41,12 @@ python3Packages.buildPythonApplication rec {
src = ./fix-rpath.patch;
inherit (builtins) storeDir;
})

# Support Python 3.7. This is part of 0.47 and 0.48.1.
(fetchpatch {
url = https://github.com/mesonbuild/meson/commit/a87496addd9160300837aa50193f4798c6f1d251.patch;
sha256 = "1jfn9dgib5bc8frcd65cxn3fzhp19bpbjadxjkqzbjk1v4hdbl88";
})
];

setupHook = ./setup-hook.sh;
4 changes: 2 additions & 2 deletions pkgs/os-specific/linux/ati-drivers/default.nix
Original file line number Diff line number Diff line change
@@ -61,8 +61,8 @@ stdenv.mkDerivation rec {
src = fetchurl {
url =
"https://www2.ati.com/drivers/linux/radeon-crimson-15.12-15.302-151217a-297685e.zip";
sha256 = "0n0ynqmjkjp5dl5q07as7ps3rlyyn63hq4mlwgd7c7v82ky2skvh";
curlOpts = "--referer http://support.amd.com/en-us/download/desktop?os=Linux+x86_64";
sha256 = "704f2dfc14681f76dae3b4120c87b1ded33cf43d5a1d800b6de5ca292bb61e58";
curlOpts = "--referer https://www.amd.com/en/support";
};

hardeningDisable = [ "pic" "format" ];
25 changes: 20 additions & 5 deletions pkgs/os-specific/linux/systemd/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, lib, fetchFromGitHub, fetchpatch, pkgconfig, intltool, gperf, libcap, kmod
{ stdenv, lib, fetchFromGitHub, fetchpatch, fetchurl, pkgconfig, intltool, gperf, libcap, kmod
, xz, pam, acl, libuuid, m4, utillinux, libffi
, glib, kbd, libxslt, coreutils, libgcrypt, libgpgerror, libidn2, libapparmor
, audit, lz4, bzip2, libmicrohttpd, pcre2
@@ -18,18 +18,34 @@ let
pythonLxmlEnv = buildPackages.python3Packages.python.withPackages ( ps: with ps; [ python3Packages.lxml ]);

in stdenv.mkDerivation rec {
version = "239.20181031";
version = "239";
name = "systemd-${version}";

# When updating, use https://github.com/systemd/systemd-stable tree, not the development one!
# Also fresh patches should be cherry-picked from that tree to our current one.
src = fetchFromGitHub {
owner = "NixOS";
repo = "systemd";
rev = "nixos-v${version}";
sha256 = "1rzl0iqrpa4ajvama5k3cb3yc7893c55kzcxkl3cyavpdzsw5505";
rev = "31859ddd35fc3fa82a583744caa836d356c31d7f";
sha256 = "1xci0491j95vdjgs397n618zii3sgwnvanirkblqqw6bcvcjvir1";
};

prePatch = let
# Upstream's maintenance branches are still too intrusive:
# https://github.com/systemd/systemd-stable/tree/v239-stable
patches-deb = fetchurl {
# When the URL disappears, it typically means that Debian has new patches
# (probably security) and updating to new tarball will apply them as well.
name = "systemd-debian-patches.tar.xz";
url = mirror://debian/pool/main/s/systemd/systemd_239-11~bpo9+1.debian.tar.xz;
sha256 = "136f6p4jbi4z94mf4g099dfcacwka8jwhza0wxxw2q5l5q3xiysh";
};
# Note that we skip debian-specific patches, i.e. ./debian/patches/debian/*
in ''
tar xf ${patches-deb}
patches="$patches $(cat debian/patches/series | grep -v '^debian/' | sed 's|^|debian/patches/|')"
'';

outputs = [ "out" "lib" "man" "dev" ];

nativeBuildInputs =
@@ -91,7 +107,6 @@ in stdenv.mkDerivation rec {
"-Dsulogin-path=${utillinux}/bin/sulogin"
"-Dmount-path=${utillinux}/bin/mount"
"-Dumount-path=${utillinux}/bin/umount"
"-Ddns-over-tls=false"
];

preConfigure = ''
13 changes: 1 addition & 12 deletions pkgs/stdenv/generic/make-derivation.nix
Original file line number Diff line number Diff line change
@@ -12,9 +12,7 @@ rec {
# * https://nixos.org/nix/manual/#ssec-derivation
# Explanation about derivations in general
mkDerivation =
{ name ? if attrs ? pname && attrs ? version
then "${attrs.pname}-${attrs.version}"
else ""
{ name ? ""

# These types of dependencies are all exhaustively documented in
# the "Specifying Dependencies" section of the "Standard
@@ -67,8 +65,6 @@ rec {
, pos ? # position used in error messages and for meta.position
(if attrs.meta.description or null != null
then builtins.unsafeGetAttrPos "description" attrs.meta
else if attrs.version or null != null
then builtins.unsafeGetAttrPos "version" attrs
else builtins.unsafeGetAttrPos "name" attrs)
, separateDebugInfo ? false
, outputs ? [ "out" ]
@@ -82,13 +78,6 @@ rec {

, ... } @ attrs:

# Check that the name is consistent with pname and version:
assert lib.assertMsg
(lib.lists.all (name: builtins.hasAttr name attrs) ["name" "pname" "version"]
-> lib.strings.hasSuffix "${attrs.pname}-${attrs.version}" attrs.name)
("mkDerivation: `name` (\"${attrs.name}\") must be consistent " +
"with `pname-version` \"${attrs.pname}-${attrs.version}\"");

let
# TODO(@oxij, @Ericson2314): This is here to keep the old semantics, remove when
# no package has `doCheck = true`.
15 changes: 9 additions & 6 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
@@ -17235,6 +17235,8 @@ with pkgs;

slack-cli = callPackage ../tools/networking/slack-cli { };

slack-term = callPackage ../applications/networking/instant-messengers/slack-term { };

singularity = callPackage ../applications/virtualization/singularity { };

spectmorph = callPackage ../applications/audio/spectmorph { };
@@ -21359,13 +21361,14 @@ with pkgs;
boogie = dotnetPackages.Boogie;

inherit (callPackage ./coq-packages.nix {
inherit (ocaml-ng) ocamlPackages_4_02
ocamlPackages_4_05
;
inherit (ocaml-ng) ocamlPackages_4_05;
}) mkCoqPackages
coq_8_5 coq_8_6 coq_8_7 coq_8_8
coqPackages_8_5 coqPackages_8_6 coqPackages_8_7 coqPackages_8_8
coqPackages coq
coqPackages_8_5 coq_8_5
coqPackages_8_6 coq_8_6
coqPackages_8_7 coq_8_7
coqPackages_8_8 coq_8_8
coqPackages_8_9 coq_8_9
coqPackages coq
;

coq2html = callPackage ../applications/science/logic/coq2html {
10 changes: 5 additions & 5 deletions pkgs/top-level/coq-packages.nix
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
{ lib, callPackage, newScope, recurseIntoAttrs
, gnumake3
, ocamlPackages_4_02
, ocamlPackages_4_05
}:
{ lib, callPackage, newScope, recurseIntoAttrs, ocamlPackages_4_05 }:

let
mkCoqPackages' = self: coq:
@@ -70,11 +66,15 @@ in rec {
coq_8_8 = callPackage ../applications/science/logic/coq {
version = "8.8.2";
};
coq_8_9 = callPackage ../applications/science/logic/coq {
version = "8.9+beta1";
};

coqPackages_8_5 = mkCoqPackages coq_8_5;
coqPackages_8_6 = mkCoqPackages coq_8_6;
coqPackages_8_7 = mkCoqPackages coq_8_7;
coqPackages_8_8 = mkCoqPackages coq_8_8;
coqPackages_8_9 = mkCoqPackages coq_8_9;
coqPackages = coqPackages_8_8;
coq = coqPackages.coq;