Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-deps: 2018-08-16 -> 2018-11-01 #49738

Merged
merged 1 commit into from Nov 4, 2018
Merged

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Nov 4, 2018

Motivation for this change

Fixes #49640.

This broke when I updated bazel, I guess something changed with how bazel fetch works. The new version of bazel-deps has dependencies declared in a way that interacts correctly with bazel fetch in the current version of bazel, so I updated it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018

@GrahamcOfBorg build bazel-deps

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-deps

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bazel-deps

Partial log (click to expand)

INFO: 59 processes: 55 processwrapper-sandbox, 4 worker.
INFO: Build completed successfully, 97 total actions
INFO: Build completed successfully, 97 total actions
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4zk33c6x8mq66d57233579khl729f3ab-bazel-deps-2018-11-01/bin
patching script interpreter paths in /nix/store/4zk33c6x8mq66d57233579khl729f3ab-bazel-deps-2018-11-01
/nix/store/4zk33c6x8mq66d57233579khl729f3ab-bazel-deps-2018-11-01/bin/.gen_maven_deps.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/4zk33c6x8mq66d57233579khl729f3ab-bazel-deps-2018-11-01

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bazel-deps

Partial log (click to expand)

INFO: Build completed successfully, 97 total actions
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jdalnzxdjhrf4pv97vhqn3y0g9qh5k2i-bazel-deps-2018-11-01
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jdalnzxdjhrf4pv97vhqn3y0g9qh5k2i-bazel-deps-2018-11-01/bin
patching script interpreter paths in /nix/store/jdalnzxdjhrf4pv97vhqn3y0g9qh5k2i-bazel-deps-2018-11-01
/nix/store/jdalnzxdjhrf4pv97vhqn3y0g9qh5k2i-bazel-deps-2018-11-01/bin/.gen_maven_deps.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/jdalnzxdjhrf4pv97vhqn3y0g9qh5k2i-bazel-deps-2018-11-01...
/nix/store/jdalnzxdjhrf4pv97vhqn3y0g9qh5k2i-bazel-deps-2018-11-01

@Mic92 Mic92 merged commit 0aa4a45 into NixOS:master Nov 4, 2018
@uri-canva uri-canva deleted the fix-bazel-deps branch June 29, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants