glusterfs service: Switch to simple unit instead of forking #49736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gluster's pidfile handling is bug-ridden. I have fixed https://bugzilla.redhat.com/show_bug.cgi?id=1509340 in an attempt to improve it but that is far from enough. The gluster developers describe another pidfile issue as "our brick-process management is a total nightmare", see https://github.com/gluster/glusterfs/blob/f1071f17e02502c24375c0b480d369d37f4e4054/xlators/mgmt/glusterd/src/glusterd-utils.c#L5907-L5924 I have observed multiple cases where glusterd doesn't start correctly and systemd doesn't notice because of the erroneous pidfile handling. To improve the situation, we don't let glusterd daemonize itself any more and instead use `--no-daemon` and the `Simple` service type.
|
The current service was based on the one in the upstream repository. But I'm completly fine if we change it for NixOS as I also don't like the complexity of pid files. |
bachp
approved these changes
Nov 4, 2018
|
@bachp That's right. Note gluster may still be as confused as before about its own children, but at least with this patch, systemd knows correctly whether gluster is running or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Gluster's pidfile handling is bug-ridden.
I have fixed https://bugzilla.redhat.com/show_bug.cgi?id=1509340
in an attempt to improve it but that is far from enough.
The gluster developers describe another pidfile issue as
"our brick-process management is a total nightmare", see
https://github.com/gluster/glusterfs/blob/f1071f17e02502c24375c0b480d369d37f4e4054/xlators/mgmt/glusterd/src/glusterd-utils.c#L5907-L5924
I have observed multiple cases where glusterd doesn't start correctly
and systemd doesn't notice because of the erroneous pidfile handling.
To improve the situation, we don't let glusterd daemonize itself any more
and instead use
--no-daemonand theSimpleservice type.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)CC @bachp
I have tested this for a long time on my Gluster cluster.
Now I'm moved to ceph, but I still want to upstream the improvements to NixOS.