Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yacreader: init at 9.5.0, libunarr: init at 1.0.1 #49737

Merged
merged 1 commit into from Nov 9, 2018
Merged

yacreader: init at 9.5.0, libunarr: init at 1.0.1 #49737

merged 1 commit into from Nov 9, 2018

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Nov 4, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add enableParallelBuilding = true; to both packages

It builds fine on nixos-18.09 otherwise

pkgs/applications/graphics/yacreader/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libunarr/default.nix Outdated Show resolved Hide resolved
@cocreature
Copy link
Contributor Author

Thanks for the feedback @c0bw3b. I think I addressed all of your requests.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 9, 2018

@GrahamcOfBorg build libunarr yacreader

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libunarr, yacreader

Partial log (click to expand)

shrinking /nix/store/b60crl0qm5c16mwhvbrws66mn75lrj3h-yacreader-9.5.0/bin/YACReader
gzipping man pages under /nix/store/b60crl0qm5c16mwhvbrws66mn75lrj3h-yacreader-9.5.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b60crl0qm5c16mwhvbrws66mn75lrj3h-yacreader-9.5.0/bin
patching script interpreter paths in /nix/store/b60crl0qm5c16mwhvbrws66mn75lrj3h-yacreader-9.5.0
checking for references to /build in /nix/store/b60crl0qm5c16mwhvbrws66mn75lrj3h-yacreader-9.5.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/xm8y77js158341c7gp28xrvjaj4m2gfh-libunarr-1.0.1
/nix/store/b60crl0qm5c16mwhvbrws66mn75lrj3h-yacreader-9.5.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libunarr, yacreader

Partial log (click to expand)

shrinking /nix/store/hixd98qb2fqbsyqfvi73a0njsq7gi66b-yacreader-9.5.0/bin/YACReader
gzipping man pages under /nix/store/hixd98qb2fqbsyqfvi73a0njsq7gi66b-yacreader-9.5.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hixd98qb2fqbsyqfvi73a0njsq7gi66b-yacreader-9.5.0/bin
patching script interpreter paths in /nix/store/hixd98qb2fqbsyqfvi73a0njsq7gi66b-yacreader-9.5.0
checking for references to /build in /nix/store/hixd98qb2fqbsyqfvi73a0njsq7gi66b-yacreader-9.5.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/q2yqzh61rb0s6v961sjcwy0is3j50nmi-libunarr-1.0.1
/nix/store/hixd98qb2fqbsyqfvi73a0njsq7gi66b-yacreader-9.5.0

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 9, 2018

Yheah much faster builds!

@c0bw3b c0bw3b merged commit 0fcf198 into NixOS:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cocreature @c0bw3b @GrahamcOfBorg