Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 60.2.1 -> 60.3.0 [Critical security fixes] #49677

Merged
merged 2 commits into from Nov 3, 2018
Merged

thunderbird, thunderbird-bin: 60.2.1 -> 60.3.0 [Critical security fixes] #49677

merged 2 commits into from Nov 3, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 3, 2018

Motivation for this change
  • Critical security fixes
  • Other fixes

https://www.thunderbird.net/en-US/thunderbird/60.3.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2018-28/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vcunat vcunat self-assigned this Nov 3, 2018
vcunat
vcunat approved these changes Nov 3, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to run OK.

@vcunat vcunat merged commit 09d49a1 into NixOS:master Nov 3, 2018
vcunat added a commit that referenced this pull request Nov 3, 2018
@vcunat
Merge #49677: thunderbird*: 60.2.1 -> 60.3.0
f3cca2f 
Critical security fixes.
vcunat added a commit that referenced this pull request Nov 3, 2018
@vcunat
Merge #49677: thunderbird*: 60.2.1 -> 60.3.0
5b94195 
Critical security fixes.

(cherry picked from commit f3cca2f)
@vcunat
Copy link
Member

vcunat commented Nov 3, 2018

Picked to 18.09 as well, after some testing there.

andir pushed a commit to andir/nixpkgs that referenced this pull request Nov 16, 2018
@vcunat @andir
Merge NixOS#49677: thunderbird*: 60.2.1 -> 60.3.0
f6112b2 
Critical security fixes.

(cherry picked from commit 5b94195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @GrahamcOfBorg