Update jupyter packages to python 3 only packages with 27 support #49721
Conversation
costrouc
changed the title
|
Success on x86_64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
costrouc
force-pushed
the
costrouc/jupyter-update
branch
from
5b81a48
to
161d34c
Compare
|
Fixed with all the recommended changes. |
|
Success on x86_64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
Bump. I should also add this this PR will enable "auto-install" of extensions which should make #49807 much easier. This package should be ready for merge. No python 27, 3+ support was lost. Only separated to allow upgrade of package and easy removal of 27 support in the future. |
…7.0 -> 7.1.1 - removed patch for sage as it is applied in most recent release. - simplified `ipython` attribute no need for explicit version `5` vs. `6`. - upgrade to most recent version of ipython
Created a version to prompt_toolkit_1 for legacy ipython
costrouc
force-pushed
the
costrouc/jupyter-update
branch
from
161d34c
to
905af80
Compare
|
@GrahamcOfBorg build python36Packages.ipython python36Packages.prompt_toolkit python36Packages.notebook python36Packages.prompt_toolkit python36Packages.ipykernel python36Packages.jupyterlab_server python36Packages.jupyterlab python36Packages.jupyterhub |
|
Success on x86_64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python36Packages.ipython, python36Packages.prompt_toolkit, python36Packages.notebook, python36Packages.prompt_toolkit, python36Packages.ipykernel, python36Packages.jupyterlab_server, python36Packages.jupyterlab, python36Packages.jupyterhub Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python36Packages.ipython, python36Packages.prompt_toolkit, python36Packages.notebook, python36Packages.prompt_toolkit, python36Packages.ipykernel, python36Packages.jupyterlab_server, python36Packages.jupyterlab, python36Packages.jupyterhub Partial log (click to expand)
|
|
@GrahamcOfBorg build python27Packages.jupyter python27Packages.jupyter_console |
|
Failure on x86_64-linux (full log) Attempted: python27Packages.jupyter, python27Packages.jupyter_console Partial log (click to expand)
|
|
I get the same build errors. |
|
Failure on x86_64-darwin (full log) Attempted: python27Packages.jupyter, python27Packages.jupyter_console Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: python27Packages.jupyter, python27Packages.jupyter_console Partial log (click to expand)
|
|
@Mic92 thanks for checking and catching that. I am fixing the error right now. It had to do with me rebasing with a recent commit that changed I often resort to |
|
THANK YOU and written by none other than yourself. I guess I had seen that tool but never thought it was applicable to my use case (should have RTFM). I will do this to confirm my PRs in the future (and now)! |
costrouc
force-pushed
the
costrouc/jupyter-update
branch
from
905af80
to
50a93a4
Compare
|
Success on x86_64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python27Packages.ipython, python36Packages.jupyter_console Partial log (click to expand)
|
|
I will also be closing this along with two other PRs to combine with this one. #49807, #49721, and #50858. This will lead to a PR with better python 3 support for jupyter (newest releases are python 3.5+ only). Addition of 3 kernels (c, go, ansible) and 20 jupyterlab extensions. Also will have an editor that has a clean way to add kernels and extensions. This will be a big PR but I am finding that they all depend on each other. |
|
I seem to have forgotten to mention it, but these changes have landed in master. |
|
An important change I made is that with Python 2 one always gets prompt_toolkit version 1, and with Python 3 always version 2. |
Motivation for this change & Things done
Jupyter has moved their releases to only supporting python 3+. This has blocked upgrading of several python packages within
nixpkgs. These includeipython,ipykernel, andjupyter. This PR upgrades to newest releases while keeping python 2.7 support for these packages as well.I would like input on if this is the appropriate way to support multiple versions. The important details are in the changes to
python-packages.nixThis expression allows support for the most recent versions of
ipythonfor each python version.This update required making
prompt_toolkit2.x.x the default version. I have ensure that all applications that depended on prompt_toolkit 1.x.x still work. This issue was addressed recently with #49853.sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)