Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.*.env: Fixed shellHook being ignored #49758

Merged
merged 1 commit into from Nov 4, 2018
Merged

haskellPackages.*.env: Fixed shellHook being ignored #49758

merged 1 commit into from Nov 4, 2018

Conversation

FPtje
Copy link
Contributor

@FPtje FPtje commented Nov 4, 2018 •
edited

Motivation for this change

The problem was introduced in 2bafa93. Shellhook was being ignored entirely.

Pinging @infinisil and @ElvishJerricco, as they might want to review the change. I'm not well acquainted
with shellFor, so the addition might not be the right way to do it. Also, maybe other stuff should be in there?

If this PR is merged, could it be backported to release-18.09?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" -> Nothing changed
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

ElvishJerricco
ElvishJerricco approved these changes Nov 4, 2018
View reviewed changes
Copy link
Contributor

@ElvishJerricco ElvishJerricco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

infinisil
infinisil approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh darn, yeah my mistake. Yeah that's the correct way to fix it.

@infinisil infinisil merged commit 1dd6445 into NixOS:master Nov 4, 2018
@infinisil
Copy link
Member

Can you make a PR for the backport?

@basvandijk
Copy link
Member

I just backported this in bf7930d.

Thanks Falco!

@FPtje FPtje deleted the fix-shellhook-ignore-haskell branch November 4, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvishJerricco ElvishJerricco ElvishJerricco approved these changes

@infinisil infinisil infinisil approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FPtje @infinisil @basvandijk @ElvishJerricco @GrahamcOfBorg