Skip to content

i3: 4.15 -> 4.16 #49757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

i3: 4.15 -> 4.16 #49757

merged 1 commit into from
Nov 7, 2018
+2 −2

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 4, 2018 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Moredread
i3: 4.15 -> 4.16

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
a7b471a
@Moredread
Copy link
Contributor Author

I think this might be a candidate for a backport to nixos-18.09, as the release notes state

This version is considered stable. All users of i3 are
strongly encouraged to upgrade.

This release contains a number of assorted fixes and improvements across pretty
much all individual components of i3.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 4, 2018
@Moredread
Copy link
Contributor Author

cc @garbas @modulistic @fpletz

@7c6f434c
Copy link
Member

7c6f434c commented Nov 5, 2018

@GrahamcOfBorg build i3

@7c6f434c
Copy link
Member

7c6f434c commented Nov 5, 2018

@GrahamcOfBorg test i3wm

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: i3

Partial log (click to expand)

Cannot nix-instantiate `i3' because:
error: assertion failed at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:178:18

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: i3

Partial log (click to expand)

shrinking /nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16/bin/i3-config-wizard
shrinking /nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16/bin/i3
shrinking /nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16/bin/i3-dump-log
gzipping man pages under /nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16/share/man/
patching script interpreter paths in /nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16
checking for references to /build in /nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16...
shrinking RPATHs of ELF executables and libraries in /nix/store/rn5xyhjjfrx5119w2cf8hm3cd63wx3qm-i3-4.16-debug
patching script interpreter paths in /nix/store/rn5xyhjjfrx5119w2cf8hm3cd63wx3qm-i3-4.16-debug
checking for references to /build in /nix/store/rn5xyhjjfrx5119w2cf8hm3cd63wx3qm-i3-4.16-debug...
/nix/store/f91aba7rla8g8kvs9fj6qf0j24vdlz41-i3-4.16

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.i3wm

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 35.19s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/yjyx88sd4ssq7gvrw7zlwy5mgprhy799-vm-test-run-i3wm

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: i3

Partial log (click to expand)

shrinking /nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16/bin/i3-input
shrinking /nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16/bin/i3-msg
shrinking /nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16/bin/i3-nagbar
gzipping man pages under /nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16/share/man/
patching script interpreter paths in /nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16
checking for references to /build in /nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16...
shrinking RPATHs of ELF executables and libraries in /nix/store/7x4kz8z7xan3nzvb0lag6w7zqjanznlm-i3-4.16-debug
patching script interpreter paths in /nix/store/7x4kz8z7xan3nzvb0lag6w7zqjanznlm-i3-4.16-debug
checking for references to /build in /nix/store/7x4kz8z7xan3nzvb0lag6w7zqjanznlm-i3-4.16-debug...
/nix/store/7l14cy9n2wj86apirdk4p7wpc41s4ki3-i3-4.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.i3wm

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 44.32s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/v30dx4lr2n2311jfl8h4p0xn22yjpvnp-vm-test-run-i3wm

@7c6f434c 7c6f434c merged commit 2b835ae into NixOS:master Nov 7, 2018
@Moredread Moredread deleted the bump/i3-4.16 branch November 8, 2018 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @7c6f434c @GrahamcOfBorg