Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/packages: display license long name first #249

Merged
merged 1 commit into from Nov 5, 2018
Merged

nixos/packages: display license long name first #249

merged 1 commit into from Nov 5, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 4, 2018

It seems to me that any licenses' long name is the most human-friendly attribute for presentation on a website. fullName is intended to be a text string for human presentation.

Then comes SPDX ids (if defined) which were made to be both human and machine-readable.

nix-repl> stdenv.lib.licenses.bsl11
{ fullName = "Business Source License 1.1"; shortName = "bsl11"; url = "https://mariadb.com/bsl11"; }

nix-repl> stdenv.lib.licenses.lppl13c
{ fullName = "LaTeX Project Public License v1.3c"; shortName = "lppl13c"; spdxId = "LPPL-1.3c"; url = "http://spdx.org/licenses/LPPL-1.3c.html"; }

nix-repl> stdenv.lib.licenses.cc-by-sa-40
{ fullName = "Creative Commons Attribution Share Alike 4.0"; shortName = "cc-by-sa-40"; spdxId = "CC-BY-SA-4.0"; url = "http://spdx.org/licenses/CC-BY-SA-4.0.html"; }

cc @samueldr

@c0bw3b
nixos/packages: display license long name first
bcedfcf 
Long name is the most human-readable attribute
then comes SPDX id or short name
samueldr
samueldr approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Verified, works.

The only drawback this could have (and is the tiniest one, to be ignored) is that packages with multiple licenses could have the license line take up more space than previously. For the sake of clarity, this is entirely better.

@edolstra edolstra merged commit a6d732a into NixOS:master Nov 5, 2018
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 5, 2018

Thanks.

@samueldr yes same as the Nix expression path or maintainers list.
But if it needs more than one line to be displayed the block adapts so that's covered already.

@c0bw3b c0bw3b deleted the licenses-presentation branch April 22, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @samueldr @edolstra