Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matplotlib: 2.2.3 -> 3.0.0 #49686

Closed
wants to merge 2 commits into from
Closed

matplotlib: 2.2.3 -> 3.0.0 #49686

wants to merge 2 commits into from

Conversation

smaret
Copy link
Member

@smaret smaret commented Nov 3, 2018

Motivation for this change

Update matplotlib to the latest upstream version (3.0.0). This version does not support Python 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@smaret smaret requested a review from FRidh as a code owner November 3, 2018 12:46
@smaret
Copy link
Member Author

smaret commented Nov 3, 2018

Should we keep the old version of matplotlib in nixpkgs for Python2 users?

@smaret
Copy link
Member Author

smaret commented Nov 3, 2018

CC'ing the package maintainer @lovek323

@FRidh
Copy link
Member

FRidh commented Nov 3, 2018

Yes, we need to keep a version for Python 2.

@smaret smaret changed the title [WIP] matplotlib: 2.2.3 -> 3.0.0 matplotlib: 2.2.3 -> 3.0.0 Nov 3, 2018
@smaret
Copy link
Member Author

smaret commented Nov 3, 2018

@GrahamcOfBorg build python36Packages.matplotlib

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.matplotlib

Partial log (click to expand)

shrinking /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/ft2font.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/_path.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/_tri.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/_image.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/ttconv.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0/lib
patching script interpreter paths in /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0
checking for references to /build in /nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0...
/nix/store/vh4wk52lsndmkjs3c88k73zdfi255k42-python3.6-matplotlib-3.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.matplotlib

Partial log (click to expand)

shrinking /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/_png.cpython-36m-aarch64-linux-gnu.so
shrinking /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/_qhull.cpython-36m-aarch64-linux-gnu.so
shrinking /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/_tri.cpython-36m-aarch64-linux-gnu.so
shrinking /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/ft2font.cpython-36m-aarch64-linux-gnu.so
shrinking /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0/lib/python3.6/site-packages/matplotlib/ttconv.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0/lib
patching script interpreter paths in /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0
checking for references to /build in /nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0...
/nix/store/sw0iclsv73jb7jqgjczymj8c8am988y0-python3.6-matplotlib-3.0.0

@smaret
Copy link
Member Author

smaret commented Nov 3, 2018

@GrahamcOfBorg build python27Packages.matplotlib

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.matplotlib

Partial log (click to expand)

copying path '/nix/store/69jfahv7yfy45wzgjfx79sq0z96gzwyw-python2.7-setuptools_scm-3.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/281q69f2wkzi9bdwfs2rlalcyrhrd2yb-python2.7-six-1.11.0' from 'https://cache.nixos.org'...
copying path '/nix/store/93czxciidxq1cz1ym3vd2m6f0mhpa6pi-python2.7-subprocess32-3.5.2' from 'https://cache.nixos.org'...
copying path '/nix/store/kgkic5ji9pyiih62f4vgh4rnxpyjnbwz-python2.7-cycler-0.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ln2lkf4apyjqsrwvqhgz3nivsr4d86z6-python2.7-mock-2.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/fa8rkwq45bycm74ncq9fpf9ls7lsd5ch-python2.7-python-dateutil-2.7.3' from 'https://cache.nixos.org'...
copying path '/nix/store/r31l8i2kcx9kl3b7x03ssdzbdkwj5khg-python2.7-singledispatch-3.4.0.3' from 'https://cache.nixos.org'...
copying path '/nix/store/fds8vcd0gqzk7m2xzgvnlzxmawgn1jkl-python2.7-tornado-5.1' from 'https://cache.nixos.org'...
copying path '/nix/store/f1nijdn7xf5phzil3dqjbx5s8nghx907-python2.7-matplotlib-2.2.3' from 'https://cache.nixos.org'...
/nix/store/f1nijdn7xf5phzil3dqjbx5s8nghx907-python2.7-matplotlib-2.2.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.matplotlib

Partial log (click to expand)

shrinking /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/_png.so
shrinking /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/_qhull.so
shrinking /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/_tri.so
shrinking /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/ft2font.so
shrinking /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3/lib/python2.7/site-packages/matplotlib/ttconv.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3/lib
patching script interpreter paths in /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3
checking for references to /build in /nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3...
/nix/store/0000ab329ryvc3gxycqa7wz5sd9zf57s-python2.7-matplotlib-2.2.3

@FRidh FRidh self-assigned this Nov 3, 2018
@FRidh
Copy link
Member

FRidh commented Nov 11, 2018

Thanks. I've pushed 880fae6 to master.

@FRidh FRidh closed this Nov 11, 2018
@smaret smaret deleted the matplotlib-update branch April 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smaret @FRidh @GrahamcOfBorg