Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptopenjdk-openj9-bin: 11 -> 11.0.1 [Critical security fixes] #49689

Merged
merged 1 commit into from Nov 9, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 3, 2018

Motivation for this change

Oracle JDK has several security fixes. I'm not sure this applicable to OpenJ9.

https://www.oracle.com/technetwork/security-advisory/cpuoct2018-4428296.html#AppendixJAVA

AdoptOpenJDK 11.0.1 for Hotspot is not released yet. I changed the package structure so that OpenJ9 may have different version than Hotspot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 9, 2018

@GrahamcOfBorg build adoptopenjdk-jre-openj9-bin-11 adoptopenjdk-openj9-bin-11

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: adoptopenjdk-jre-openj9-bin-11, adoptopenjdk-openj9-bin-11

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: adoptopenjdk-jre-openj9-bin-11, adoptopenjdk-openj9-bin-11

Partial log (click to expand)

shrinking /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1/bin/jdb
shrinking /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1/bin/javadoc
shrinking /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1/bin/jdeps
shrinking /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1/bin/pack200
shrinking /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1/bin/jrunscript
gzipping man pages under /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1/share/man/
patching script interpreter paths in /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1
checking for references to /build in /nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1...
/nix/store/sl7smq89wn52176ny237snc9aibkyjgw-adoptopenjdk-jre-openj9-bin-11.0.1
/nix/store/cmrqw0i9k8ln94d1749a197lz0r3fxn9-adoptopenjdk-openj9-bin-11.0.1

@c0bw3b c0bw3b merged commit a232d0b into NixOS:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants