Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-install: provide user feedback when nixos install begins. #49688

Closed
wants to merge 1 commit into from
Closed

nixos-install: provide user feedback when nixos install begins. #49688

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 3, 2018

Since it might take a while before the actual download start
because of evaluation and checking the binary cache,
we should give the user give an status update that our script actually continues.
Noticed in this review: https://www.youtube.com/watch?v=QujRHErFG4w

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
nixos-install: provide user feedback when nixos install begins.
c26a016 
Since it might take a while before the actual download start
because of evaluation and checking the binary cache,
we should give the user give an status update that our script actually continues.
Noticed in this review: https://www.youtube.com/watch?v=QujRHErFG4w
@Mic92
Copy link
Member Author

Mic92 commented Nov 3, 2018

@GrahamcOfBorg test installer.simple

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.installer.simple

Partial log (click to expand)

error: while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/nixos/release.nix:32:25, called from undefined position:
while evaluating 'hydraJob' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/lib/customisation.nix:157:14, called from /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/nixos/release.nix:32:28:
while evaluating the attribute 'drvPath' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/lib/customisation.nix:174:13:
while evaluating the attribute 'drvPath' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/lib/customisation.nix:141:13:
while evaluating the attribute 'buildCommand' of the derivation 'vm-test-run-installer-simple' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/pkgs/stdenv/generic/make-derivation.nix:178:11:
while evaluating the attribute 'testScript' of the derivation 'nixos-test-driver-installer-simple' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/pkgs/stdenv/generic/make-derivation.nix:178:11:
while evaluating 'isFunction' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/lib/trivial.nix:288:16, called from /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/nixos/lib/testing.nix:104:12:
while evaluating 'testScriptFun' at /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/nixos/tests/installer.nix:65:19, called from /var/lib/gc-of-borg/nix-test-rs-4/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-4/nixos/tests/installer.nix:267:20:
Non-EFI boot methods are only supported on i686 / x86_64

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.installer.simple

Partial log (click to expand)

machine# [   19.177121] systemd-shutdown[1]: All loop devices detached.
machine# [   19.179638] systemd-shutdown[1]: Detaching DM devices.
machine# [   19.189794] ACPI: Preparing to enter system sleep state S5
machine# [   19.192428] reboot: Power down
collecting coverage data
syncing
test script finished in 1021.00s
vde_switch: EOF on stdin, cleaning up and exiting
cleaning up
/nix/store/ifbs5rp3crv329lnqxd7phrjmv0xi92y-vm-test-run-installer-simple

Mic92
Mic92 commented Nov 3, 2018
View reviewed changes
nixos/modules/installer/tools/nixos-install.sh
@@ -101,6 +101,7 @@ fi
# Set the system profile to point to the configuration. TODO: combine
# this with the previous step once we have a nix-env replacement with
# a progress bar.
echo "installing system..."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm this might be not required since the download already happen in nix build above?

@Mic92 Mic92 closed this Nov 3, 2018
@Mic92 Mic92 deleted the nixos-install-ux branch November 3, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg