Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops
base: 4d8a49eb632c
Choose a base ref
...
head repository: NixOS/nixops
compare: f79a7494b5ef
Choose a head ref
  • 8 commits
  • 9 files changed
  • 2 contributors

Commits on Nov 2, 2018

  1. release.nix; add mypy dependencies

    Typing is a backport of python3 python module.
    Once we have python3 it becomes obsolete.
    Mic92 committed Nov 2, 2018
    Copy the full SHA
    13b5364 View commit details
    Browse the repository at this point in the history
  2. setup.cfg: add mypy configuration.

    We ignore all third-party dependencies by default.
    This might look verbose on first look however it has the advantage
    this way we can easily see if we accidentally add new dependencies
    and we can detect typos in local imports.
    The alternative would be to ignore all missing imports instead.
    Mic92 committed Nov 2, 2018
    Copy the full SHA
    be53749 View commit details
    Browse the repository at this point in the history
  3. hetzner: avoid shadowing variable

    cmd is defined later as a string.
    Mic92 committed Nov 2, 2018
    Copy the full SHA
    725ddfc View commit details
    Browse the repository at this point in the history
  4. treewide: ignore type for urllib.parse.quote import

    Mypy does not like re-imports from different modules.
    We can later drop this statement when we switch to python3.
    Mic92 committed Nov 2, 2018
    Copy the full SHA
    1e8b560 View commit details
    Browse the repository at this point in the history
  5. nixops.diff.Handler: avoid overriding member methods.

    Mypy complaints about this line.
    In this file I also added a more comprehensive example for typing annotation.
    Note that python3 has a nicer language builtin syntax.
    The currently used type annotations will be still compatible with python3 and
    can be ported on demand.
    Mic92 committed Nov 2, 2018
    Copy the full SHA
    9ca2002 View commit details
    Browse the repository at this point in the history
  6. azure_common: add explite type annotation for tokens

    For a few container types mypy is not able to interfere the type
    automatically. In those cases it asks the user to provide a type
    manually.
    Mic92 committed Nov 2, 2018
    Copy the full SHA
    360fd4d View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    0f95286 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2018

  1. Merge pull request #1039 from Mic92/mypy

    Check types wit mypy
    domenkozar committed Nov 4, 2018
    Copy the full SHA
    f79a749 View commit details
    Browse the repository at this point in the history