-
-
Notifications
You must be signed in to change notification settings - Fork 362
Comparing changes
Open a pull request
base repository: NixOS/nixops
base: 4d8a49eb632c
head repository: NixOS/nixops
compare: f79a7494b5ef
- 8 commits
- 9 files changed
- 2 contributors
Commits on Nov 2, 2018
-
release.nix; add mypy dependencies
Typing is a backport of python3 python module. Once we have python3 it becomes obsolete.
Configuration menu - View commit details
-
Copy full SHA for 13b5364 - Browse repository at this point
Copy the full SHA 13b5364View commit details -
setup.cfg: add mypy configuration.
We ignore all third-party dependencies by default. This might look verbose on first look however it has the advantage this way we can easily see if we accidentally add new dependencies and we can detect typos in local imports. The alternative would be to ignore all missing imports instead.
Configuration menu - View commit details
-
Copy full SHA for be53749 - Browse repository at this point
Copy the full SHA be53749View commit details -
Configuration menu - View commit details
-
Copy full SHA for 725ddfc - Browse repository at this point
Copy the full SHA 725ddfcView commit details -
treewide: ignore type for urllib.parse.quote import
Mypy does not like re-imports from different modules. We can later drop this statement when we switch to python3.
Configuration menu - View commit details
-
Copy full SHA for 1e8b560 - Browse repository at this point
Copy the full SHA 1e8b560View commit details -
nixops.diff.Handler: avoid overriding member methods.
Mypy complaints about this line. In this file I also added a more comprehensive example for typing annotation. Note that python3 has a nicer language builtin syntax. The currently used type annotations will be still compatible with python3 and can be ported on demand.
Configuration menu - View commit details
-
Copy full SHA for 9ca2002 - Browse repository at this point
Copy the full SHA 9ca2002View commit details -
azure_common: add explite type annotation for tokens
For a few container types mypy is not able to interfere the type automatically. In those cases it asks the user to provide a type manually.
Configuration menu - View commit details
-
Copy full SHA for 360fd4d - Browse repository at this point
Copy the full SHA 360fd4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f95286 - Browse repository at this point
Copy the full SHA 0f95286View commit details
Commits on Nov 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f79a749 - Browse repository at this point
Copy the full SHA f79a749View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4d8a49eb632c...f79a7494b5ef