Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RO v13 for KSP 1.5.1 #1941

Closed
wants to merge 3 commits into from
Closed

RO v13 for KSP 1.5.1 #1941

wants to merge 3 commits into from

Conversation

raidernick
Copy link
Contributor

-Updating RO stuff for ksp 1.5.1

@raidernick raidernick added the Hold For Release Hold for next release label Nov 4, 2018
Copy link
Contributor

@Bornholio Bornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running fine sans real plume and a few other dep's not yet released (SXT and RF were only non-release mods added)

@Bornholio
Copy link
Contributor

Is there a way to do an OR on the FAR dependency?

@raidernick
Copy link
Contributor Author

I don't think ckan allows that. You can tell it not to install one if the other is installed but I don't think you can tell it to pick a specific one over the other. If they are set as "needs" then it will try to install both, but fail since they conflict.

@pianojosh
Copy link
Contributor

@raidernick I'm not 100% on how it all works, but can RO depend on some meta requirement like "FerramAerospace", and have both "FerramAerospaceResearch" and "FerramAerospaceResearchContinued" provide "FerramAerospace", similar to how RSSTextures are provided in multiple resolution options?

@raidernick
Copy link
Contributor Author

I have no clue, I know next to nothing about ckan. You'd need to ask on their git.

@Olympic1
Copy link
Contributor

@pianojosh Yes, you could do that. If you do that with the current status, only FARc will be shown as an option, but if FAR gets updated, then you get both options. This all depends on the CKAN team and the mod authors.

@raidernick
Copy link
Contributor Author

@Olympic1 you'd need to show exactly how to do that in the RO ckan file, I have no idea how to do it and don't want to mess with it and potentially break it.

@jrodrigv
Copy link

Hi guys, just wondering. Which is the "Hold on" reason? Are you waiting for a dependency to be released?

@raidernick
Copy link
Contributor Author

realfuels has only been released up to ksp 1.4.3

@raidernick raidernick added invalid and removed Hold For Release Hold for next release labels Dec 23, 2018
@raidernick
Copy link
Contributor Author

Note this is missing change to checker.cs for 1.5 version and this PR will likely be closed anyway as we are skipping 1.5 but is on hold for now.

@raidernick raidernick closed this Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants