Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.prettytable: 0.7.1 -> 0.7.2 #49675

Merged
merged 1 commit into from Nov 11, 2018
Merged

pythonPackages.prettytable: 0.7.1 -> 0.7.2 #49675

merged 1 commit into from Nov 11, 2018

Conversation

asymmetric
Copy link
Contributor

Motivation for this change

Upgrade to 0.7.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Nov 3, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All expressions have been merged to to python-modules/. Please rebase onto staging.

@asymmetric
Copy link
Contributor Author

asymmetric commented Nov 3, 2018 •
edited

So I should close this PR and reopen one against staging?

@FRidh
Copy link
Member

FRidh commented Nov 3, 2018

You can force push to your branch the fixed version.

@asymmetric
Copy link
Contributor Author

The problem is that the PR is opened against master, so I don't think it makes sense to rebase onto staging - as you can see, hundreds of commits are pulled in.

@FRidh FRidh changed the base branch from master to staging November 3, 2018 09:43
@FRidh
Copy link
Member

FRidh commented Nov 3, 2018

Not anymore.

@asymmetric
Copy link
Contributor Author

Can this be merged?

@FRidh
Copy link
Member

FRidh commented Nov 7, 2018

@GrahamcOfBorg build pythonPackages.prettytable python3Packages.prettytable

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: pythonPackages.prettytable, python3Packages.prettytable

Partial log (click to expand)


trying https://files.pythonhosted.org/packages/source/p/prettytable/prettytable-0.7.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 24784  100 24784    0     0  95323      0 --:--:-- --:--:-- --:--:-- 95323
fixed-output derivation produced path '/nix/store/gv08n8xwm1xcf63l4fdxlk6i3hhd86vf-prettytable-0.7.2.tar.gz' with sha256 hash '1ndckiniasacfqcdafzs04plskrcigk7vxprr2y34jmpkpf60m1d' instead of the expected hash '0diwsicwmiq2cpzpxri7cyl5fmsvicafw6nfqf6p6p322dji2g45'
cannot build derivation '/nix/store/0a3c5fdqgy96iycwf2gh2my2862jn40x-python2.7-prettytable-0.7.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x00ady2wh6mx6kkbgmhjzw6l6d7y12ak-python3.7-prettytable-0.7.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0a3c5fdqgy96iycwf2gh2my2862jn40x-python2.7-prettytable-0.7.2.drv', '/nix/store/x00ady2wh6mx6kkbgmhjzw6l6d7y12ak-python3.7-prettytable-0.7.2.drv' failed

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)

Attempted: pythonPackages.prettytable, python3Packages.prettytable

Partial log (click to expand)


trying https://files.pythonhosted.org/packages/source/p/prettytable/prettytable-0.7.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 24784  100 24784    0     0  74876      0 --:--:-- --:--:-- --:--:-- 74876
fixed-output derivation produced path '/nix/store/gv08n8xwm1xcf63l4fdxlk6i3hhd86vf-prettytable-0.7.2.tar.gz' with sha256 hash '1ndckiniasacfqcdafzs04plskrcigk7vxprr2y34jmpkpf60m1d' instead of the expected hash '0diwsicwmiq2cpzpxri7cyl5fmsvicafw6nfqf6p6p322dji2g45'
cannot build derivation '/nix/store/bn83l83b4qzy5fmw62sdz6vjkmvyva2g-python2.7-prettytable-0.7.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gad5s3irp0cfx28la35gm9acp52r9y22-python3.7-prettytable-0.7.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bn83l83b4qzy5fmw62sdz6vjkmvyva2g-python2.7-prettytable-0.7.2.drv', '/nix/store/gad5s3irp0cfx28la35gm9acp52r9y22-python3.7-prettytable-0.7.2.drv' failed

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: pythonPackages.prettytable, python3Packages.prettytable

Partial log (click to expand)


trying https://files.pythonhosted.org/packages/source/p/prettytable/prettytable-0.7.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 24784  100 24784    0     0   249k      0 --:--:-- --:--:-- --:--:--  249k
fixed-output derivation produced path '/nix/store/gv08n8xwm1xcf63l4fdxlk6i3hhd86vf-prettytable-0.7.2.tar.gz' with sha256 hash '1ndckiniasacfqcdafzs04plskrcigk7vxprr2y34jmpkpf60m1d' instead of the expected hash '0diwsicwmiq2cpzpxri7cyl5fmsvicafw6nfqf6p6p322dji2g45'
cannot build derivation '/nix/store/yhca10zixn2ihrd6fas96a8sij2f8icg-python2.7-prettytable-0.7.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4wb3sk9ivfsc3687c5qb64kxra1c290n-python3.7-prettytable-0.7.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4wb3sk9ivfsc3687c5qb64kxra1c290n-python3.7-prettytable-0.7.2.drv', '/nix/store/yhca10zixn2ihrd6fas96a8sij2f8icg-python2.7-prettytable-0.7.2.drv' failed

@FRidh
Copy link
Member

FRidh commented Nov 7, 2018

Incorrect hash it seems.

@asymmetric
Copy link
Contributor Author

Yup, looks like it. PTALA.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.prettytable python3Packages.prettytable

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.prettytable, python3Packages.prettytable

Partial log (click to expand)

|  京都  |  きょうと  |  Kyoto   |
|  長崎  |  ながさき  | Nagasaki |
| 名古屋 |   なごや   |  Nagoya  |
|  大阪  |  おおさか  |  Osaka   |
|  札幌  |  さっぽろ  | Sapporo  |
|  東京  | とうきょう |  Tokyo   |
|  横浜  |  よこはま  | Yokohama |
+--------+------------+----------+
/nix/store/ryv3smpdk79mggld7bwbqjnn6hzpfnpr-python2.7-prettytable-0.7.2
/nix/store/ja3408120rsihln7c01sgfy6fb43jnhy-python3.7-prettytable-0.7.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.prettytable, python3Packages.prettytable

Partial log (click to expand)

+--------+------------+----------+
|  神戸  |   こうべ   |   Kobe   |
|  京都  |  きょうと  |  Kyoto   |
|  長崎  |  ながさき  | Nagasaki |
| 名古屋 |   なごや   |  Nagoya  |
|  大阪  |  おおさか  |  Osaka   |
|  札幌  |  さっぽろ  | Sapporo  |
|  東京  | とうきょう |  Tokyo   |
|  横浜  |  よこはま  | Yokohama |
+--------+------------+----------+

@worldofpeace
Copy link
Contributor

cc @infinisil

@infinisil infinisil merged commit 5955c51 into NixOS:staging Nov 11, 2018
@asymmetric
Copy link
Contributor Author

When's the staging branch merged into master?

@worldofpeace
Copy link
Contributor

@asymmetric I think this is the current staging workflow in place.

@asymmetric
Copy link
Contributor Author

Doesn't seem like it's being followed though - the PR still hasn't landed in master.

@asymmetric
Copy link
Contributor Author

This looks relevant.

@FRidh
Copy link
Member

FRidh commented Nov 14, 2018

There are too many failures on staging-next to merge.

@asymmetric asymmetric mentioned this pull request Nov 21, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asymmetric @FRidh @GrahamcOfBorg @worldofpeace @infinisil