Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phototonic: 1.7.1 -> 2.1 #49751

Merged
merged 1 commit into from Nov 5, 2018
Merged

phototonic: 1.7.1 -> 2.1 #49751

merged 1 commit into from Nov 5, 2018

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Nov 4, 2018

Motivation for this change

update with bug fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc maintainer @pSub

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: phototonic

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fd47yahmiysm4b02xn31lk0i0iccwhpz-phototonic-2.1
shrinking /nix/store/fd47yahmiysm4b02xn31lk0i0iccwhpz-phototonic-2.1/bin/phototonic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fd47yahmiysm4b02xn31lk0i0iccwhpz-phototonic-2.1/bin
patching script interpreter paths in /nix/store/fd47yahmiysm4b02xn31lk0i0iccwhpz-phototonic-2.1
checking for references to /build in /nix/store/fd47yahmiysm4b02xn31lk0i0iccwhpz-phototonic-2.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/fd47yahmiysm4b02xn31lk0i0iccwhpz-phototonic-2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: phototonic

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ji2zxv1ba0w979wvwgam5kpqmvisv078-phototonic-2.1
shrinking /nix/store/ji2zxv1ba0w979wvwgam5kpqmvisv078-phototonic-2.1/bin/phototonic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ji2zxv1ba0w979wvwgam5kpqmvisv078-phototonic-2.1/bin
patching script interpreter paths in /nix/store/ji2zxv1ba0w979wvwgam5kpqmvisv078-phototonic-2.1
checking for references to /build in /nix/store/ji2zxv1ba0w979wvwgam5kpqmvisv078-phototonic-2.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/ji2zxv1ba0w979wvwgam5kpqmvisv078-phototonic-2.1

Moredread
Moredread approved these changes Nov 4, 2018
View reviewed changes
Copy link
Contributor

@Moredread Moredread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the sed command be replaced with substituteInPlace? Besides that it looks good! :)

@pSub pSub merged commit c7a5b77 into NixOS:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Moredread approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@woffs @GrahamcOfBorg @Moredread @pSub