Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: Add shell completions #49714

Merged
merged 2 commits into from Nov 10, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 3, 2018

This adds the remaining parts of #42657 on top of #49477

Motivation for this change

Adds shell completion to some Haskell programs, for bash, zsh and fish.

Purescript build was failing before this. It does have optparse applicative completions, so it should work out when it gets fixed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
Copy link
Member

I like your PR's generate.. name and support for multiple exes better, actually. :)

@roberth
Copy link
Member Author

roberth commented Nov 4, 2018

There you go!

Sample deprecation message:

$ nix-build -A dhall
trace: addOptparseApplicativeCompletionScripts is deprecated in favor of generateOptparseApplicativeCompletion. Please change dhall-1.15.1 to use the latter or its plural form.
/nix/store/4d8vgi6nv6grch9f1mysn97099qkw8y0-dhall-1.15.1

@roberth roberth added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 4, 2018
@roberth
Copy link
Member Author

roberth commented Nov 4, 2018

When merged, this should be backported IMO, because the 'old' version was only recently added to 18.09.

@Ericson2314
Copy link
Member

Mine was added so recently I'm not even sure the deprecation is worth it :). I'll merge now.

roberth and others added 2 commits November 8, 2018 11:28
This adds the remaining parts of NixOS#42657 on top of NixOS#49477, renames the
function to a better name, and improves the docs
@Ericson2314 Ericson2314 merged commit d681149 into NixOS:master Nov 10, 2018
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants