Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python34: remove #49730

Merged
merged 4 commits into from Nov 4, 2018
Merged

python34: remove #49730

merged 4 commits into from Nov 4, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 4, 2018

Python 3.4 will receive it's final patch release in March 2019 and there won't
be any releases anymore after that, so also not during NixOS 2019.03.

Python 3.4 is not used anymore in Nixpkgs. In any case, migrating code from
3.4 to 3.4+ is trivial.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh FRidh mentioned this pull request Nov 4, 2018
Closed
9 tasks
@FRidh
python34: remove
e32412c 
Python 3.4 will receive it's final patch release in March 2019 and there won't
be any releases anymore after that, so also not during NixOS 2019.03.

Python 3.4 is not used anymore in Nixpkgs. In any case, migrating code from
3.4 to 3.4+ is trivial.
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: retroarch

Partial log (click to expand)

In file included from ./libretro-common/include/glsym/glsym.h:26:
In file included from ./libretro-common/include/glsym/rglgen.h:32:
./libretro-common/include/glsym/rglgen_headers.h:27:10: fatal error: 'EGL/egl.h' file not found
#include <EGL/egl.h>
         ^~~~~~~~~~~
1 error generated.
make: *** [Makefile:171: obj-unix/release/gfx/drivers/gl.o] Error 1
builder for '/nix/store/bq9qhmyvklyg4nvry78faga876c13wdh-retroarch-bare-1.7.1.drv' failed with exit code 2
cannot build derivation '/nix/store/s6wy3jg8zlswgnpgmmyxmak2sz7dpgj4-retroarch-1.7.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/s6wy3jg8zlswgnpgmmyxmak2sz7dpgj4-retroarch-1.7.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: retroarch

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4rinywkm5cxks00ihdh70dfvzmn4zjzp-retroarch-bare-1.7.1
shrinking /nix/store/4rinywkm5cxks00ihdh70dfvzmn4zjzp-retroarch-bare-1.7.1/bin/.retroarch-wrapped
gzipping man pages under /nix/store/4rinywkm5cxks00ihdh70dfvzmn4zjzp-retroarch-bare-1.7.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4rinywkm5cxks00ihdh70dfvzmn4zjzp-retroarch-bare-1.7.1/bin
patching script interpreter paths in /nix/store/4rinywkm5cxks00ihdh70dfvzmn4zjzp-retroarch-bare-1.7.1
checking for references to /build in /nix/store/4rinywkm5cxks00ihdh70dfvzmn4zjzp-retroarch-bare-1.7.1...
building '/nix/store/phzp1wh3zl91j296zhswcbc3p9phfqgy-retroarch-1.7.1.drv'...
/nix/store/9c75dmx6vhviqb10c51xkanyilpmbpwi-retroarch-1.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: retroarch

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zpp810aqidrgxx5kb7dancqp2a8p14j1-retroarch-bare-1.7.1
shrinking /nix/store/zpp810aqidrgxx5kb7dancqp2a8p14j1-retroarch-bare-1.7.1/bin/.retroarch-wrapped
gzipping man pages under /nix/store/zpp810aqidrgxx5kb7dancqp2a8p14j1-retroarch-bare-1.7.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zpp810aqidrgxx5kb7dancqp2a8p14j1-retroarch-bare-1.7.1/bin
patching script interpreter paths in /nix/store/zpp810aqidrgxx5kb7dancqp2a8p14j1-retroarch-bare-1.7.1
checking for references to /build in /nix/store/zpp810aqidrgxx5kb7dancqp2a8p14j1-retroarch-bare-1.7.1...
building '/nix/store/b8qrmncabf4pw73j3ymanjhx2vzshhls-retroarch-1.7.1.drv'...
/nix/store/ri7zlxr45ffkg7gk5n8x80cpjjcngk79-retroarch-1.7.1

@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018 •
edited

cc @DarkScythe97 it seems that macOS also lacks opengl headers for retroarch

@globin globin merged commit 6a0b1b1 into NixOS:master Nov 4, 2018
globin referenced this pull request Nov 5, 2018
@FRidh @globin
python34: remove
b1bdce0 
Python 3.4 will receive it's final patch release in March 2019 and there won't
be any releases anymore after that, so also not during NixOS 2019.03.

Python 3.4 is not used anymore in Nixpkgs. In any case, migrating code from
3.4 to 3.4+ is trivial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: python 8.has: clean-up 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FRidh @GrahamcOfBorg @Mic92 @globin