Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python package set major updates #49741

Merged
merged 543 commits into from Dec 6, 2018
Merged

Python package set major updates #49741

merged 543 commits into from Dec 6, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 4, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python

Partial log (click to expand)

copying path '/nix/store/3jnjp6g1ysdw7x754283rxc6cb8560qy-ncurses-6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/975x162f3nm3ac13nfqn99rxdxfb2522-openssl-1.0.2p' from 'https://cache.nixos.org'...
copying path '/nix/store/251f3hjyih24ravx8ddfss9vwfm6dvq0-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/pjv42l4h1r0y3pkcqgbbwb2scbh7gwsg-acl-2.2.52' from 'https://cache.nixos.org'...
copying path '/nix/store/9vz0sgklpmr1m5s80yzys3ml9nlymqk1-sqlite-3.24.0' from 'https://cache.nixos.org'...
copying path '/nix/store/wfp2ypkspcx4a7ph0awa5kwy9vjwswjh-coreutils-8.30' from 'https://cache.nixos.org'...
copying path '/nix/store/1kfn90226didqra7lbwsdnhcjgps78jf-readline-6.3p08' from 'https://cache.nixos.org'...
copying path '/nix/store/ay8jfqdy1g7ldi77b1bd26hbhw6z8ndm-db-5.3.28' from 'https://cache.nixos.org'...
copying path '/nix/store/2vwrp5xwlkl9r8jiaxj85lxiv7b8kp4j-python-2.7.15' from 'https://cache.nixos.org'...
/nix/store/2vwrp5xwlkl9r8jiaxj85lxiv7b8kp4j-python-2.7.15

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python

Partial log (click to expand)

copying path '/nix/store/q92kjbb3i01dp4hpslpq7lcn8x6p1naf-gmp-6.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/x005987xqwcb89w7103xnqr7y2m934fx-coreutils-8.30' from 'https://cache.nixos.org'...
copying path '/nix/store/sl8jnxmazmi20cavdmz12nb79s3phi4q-swift-corefoundation' from 'https://cache.nixos.org'...
copying path '/nix/store/ifdm4pslw8qh3zfqdapp6kxshfs701lc-configd-osx-10.8.5' from 'https://cache.nixos.org'...
copying path '/nix/store/0xs4x0jia6q3jfdszrnxf133njym1asp-gdbm-1.18' from 'https://cache.nixos.org'...
copying path '/nix/store/7q9djnxihh7w0hd4l8dsfrn3lmwf15cp-openssl-1.0.2p' from 'https://cache.nixos.org'...
copying path '/nix/store/6rrh0ly1n7mz2nn3px0a4jywdzsng5yq-readline-6.3p08' from 'https://cache.nixos.org'...
copying path '/nix/store/dxh6blqy4714dsjdxnsxpjrf21rrq5yr-sqlite-3.24.0' from 'https://cache.nixos.org'...
copying path '/nix/store/x7iy4sqvicc3as1hq4hd5x64kdlxxryw-python-2.7.15' from 'https://cache.nixos.org'...
/nix/store/x7iy4sqvicc3as1hq4hd5x64kdlxxryw-python-2.7.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python

Partial log (click to expand)

copying path '/nix/store/rgs0rl2nr5icn0c46396drqdf9267dj3-gcc-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/df3vplpq00imj9yyk0jkywhc6wym0gdx-gdbm-1.18' from 'https://cache.nixos.org'...
copying path '/nix/store/ci7lk0iyf2na1ywnxn61xjrvkql8ax8w-db-5.3.28' from 'https://cache.nixos.org'...
copying path '/nix/store/w5bjx97a3gry1f9ah25lxl8gc4pmd9zc-ncurses-6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/nlb8hykwq7jc4vpnda39civ9cvrb7ymq-openssl-1.0.2p' from 'https://cache.nixos.org'...
copying path '/nix/store/dc1m33pqqbb6nfpnnf3w4h0v5b6rcvw6-readline-6.3p08' from 'https://cache.nixos.org'...
copying path '/nix/store/2dbjpfa4s4c51h70vbzrcbl2krw3c3z4-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/08x3hgx0izn4v0fsngchfmbqwlx4jqmw-sqlite-3.24.0' from 'https://cache.nixos.org'...
copying path '/nix/store/3wdvsid5yhvx5db3rb00jn4gwrdhqs54-python-2.7.15' from 'https://cache.nixos.org'...
/nix/store/3wdvsid5yhvx5db3rb00jn4gwrdhqs54-python-2.7.15

@dotlambda dotlambda mentioned this pull request Nov 9, 2018
Closed
gebner
gebner reviewed Nov 11, 2018
View reviewed changes
pkgs/development/python-modules/shippai/default.nix Outdated
@@ -3,11 +3,11 @@
buildPythonPackage rec {
pname = "shippai";
# Please make sure that vdirsyncer still builds if you update this package.
version = "0.2.4";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does vdirsyncer still build?

dotlambda
dotlambda reviewed Nov 12, 2018
View reviewed changes
pkgs/development/python-modules/sphinx/default.nix Outdated
@@ -25,7 +25,7 @@
}:

buildPythonPackage rec {
pname = "sphinx";
pname = "Sphinx";
Copy link
Member

@dotlambda dotlambda Nov 12, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Synthetica9 Was there a particular reason for the change? It causes sphinx to fail to build so I reverted d2e6608.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #50269

gebner
gebner requested changes Nov 15, 2018
View reviewed changes
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried to build vdirsyncer (now that rustc is in the cache), and it fails to build because of the shippai update. Could you please revert the shippai update?

@dotlambda
Copy link
Member

@ryantm Most of these conflicts are due to your bot upgrading python packages. I think you at least shouldn't do python upgrades when the package has already been upgraded in one of the staging/staging-next/python-unstable branches.

@FRidh
Copy link
Member Author

FRidh commented Nov 19, 2018

@dotlambda it's something worth considering, but I am not sure whether it is worth spending time on. These kind of merge conflicts are at least trivial to resolve, though the hash does always look differently.

@dotlambda
Copy link
Member

Alternatively, the update script could use long hashes for fetchPypi.

@ryantm
Copy link
Member

ryantm commented Nov 19, 2018

@dotlambda I check master and staging currently. I'll add staging-next and python-unstable.

@FRidh
Copy link
Member Author

FRidh commented Nov 20, 2018

@ryantm not python-unstable, there is no guarantee that changes in there go in.

@FRidh FRidh force-pushed the python-unstable branch 2 times, most recently from 22091c3 to f619f4c Compare November 21, 2018 11:26
@FRidh FRidh force-pushed the python-unstable branch 4 times, most recently from 6b3d443 to 01c320d Compare November 24, 2018 09:48
Robert Schütz and others added 20 commits December 3, 2018 16:50
@FRidh
python.pkgs.zope-hookable: init at 4.2.0
5c1367a
@FRidh
python.pkgs.zope_component: update propagatedBuildInputs
6d021d4
@FRidh
python.pkgs.h11: 0.7.0 -> 0.8.1
1d25f00
@FRidh
python.pkgs.eventlet: update propagatedBuildInputs
a568a9e
@FRidh
python.pkgs.forbiddenfruit: disable tests because they are missing in…
5e013d2 
… tarball
@FRidh
python.pkgs.paste: 3.0.4 -> 3.0.5
d43a580
@FRidh
python: pylint: 2.1.1 -> 2.2.2
8310ad1
@FRidh
python.pkgs.pylint: disable broken tests
b0c44de 
fixes #51394
@FRidh
python.pkgs.gpsoauth: 0.2.0 -> 0.4.1
0235808
@FRidh
python.pkgs.natsort: 5.4.1 -> 5.5.0
0f25705
@FRidh
python.pkgs.Nikola: apply patch for broken test
0f24133
@FRidh
python.pkgs.webtest: fix build
1122f9a
@FRidh
python.pkgs.pyacoustid: remove obsolete patch
0156fbe
@FRidh
python.pkgs.sphinx_rtd_theme: add sphinx to propagatedBuildInputs
9614364
@FRidh
python.pkgs.whisper: fix tests
f6cb659
@FRidh
python.pkgs.zconfig: remove obsolete patch
73eb15f
@FRidh
python.pkgs.zodb: remove obsolete patches and fix tests
79ced8c
@FRidh
python.pkgs.python-jose: 2.0.2 -> 3.0.1
55a8ea3
@marsam @FRidh
pythonPackages.testfixtures: 6.2.0 -> 6.3.0
75a90b5
@FRidh
python.pkgs.moto: allow newer versions of python-jose
a933c53
@Mic92
Copy link
Member

Mic92 commented Dec 3, 2018

When I have other minor python library updates that depend on updates here, should I just push them to the branch here as well?

@dotlambda
Copy link
Member

When I have other minor python library updates that depend on updates here, should I just push them to the branch here as well?

Sounds like a sensible thing to do. After you're done with that, we should definitely merge this PR!

@Mic92
Copy link
Member

Mic92 commented Dec 5, 2018 •
edited

@dotlambda you can go ahead with merging. I will add it later.

@dotlambda
Copy link
Member

@Mic92 I prefer to let @FRidh do that.

@dotlambda
Copy link
Member

@GrahamcOfBorg eval

@dotlambda dotlambda merged commit d1fe391 into staging Dec 6, 2018
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Dec 26, 2018
@orivej
pythonPackages.taskw: fix build
3fd67fb 
Broken by 8600798 in NixOS#49741.
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Dec 26, 2018
@orivej
pythonPackages.goobook: fix build
4f909b5 
Broken by e424952 in NixOS#49741.
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Dec 26, 2018
@orivej
pythonPackages.ofxparse: fix build
669705c 
Broken by 0fde2cf in NixOS#49741.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@Synthetica9 Synthetica9 Synthetica9 left review comments

@gebner gebner gebner requested changes

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet