-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python package set major updates #49741
Conversation
Success on aarch64-linux (full log) Attempted: python Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
6a9f547
to
95ef32d
Compare
ddee38b
to
c5e58fe
Compare
@@ -3,11 +3,11 @@ | |||
buildPythonPackage rec { | |||
pname = "shippai"; | |||
# Please make sure that vdirsyncer still builds if you update this package. | |||
version = "0.2.4"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does vdirsyncer still build?
@@ -25,7 +25,7 @@ | |||
}: | |||
|
|||
buildPythonPackage rec { | |||
pname = "sphinx"; | |||
pname = "Sphinx"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Synthetica9 Was there a particular reason for the change? It causes sphinx to fail to build so I reverted d2e6608.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #50269
bd47106
to
acceb53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried to build vdirsyncer
(now that rustc is in the cache), and it fails to build because of the shippai
update. Could you please revert the shippai
update?
@ryantm Most of these conflicts are due to your bot upgrading python packages. I think you at least shouldn't do python upgrades when the package has already been upgraded in one of the staging/staging-next/python-unstable branches. |
@dotlambda it's something worth considering, but I am not sure whether it is worth spending time on. These kind of merge conflicts are at least trivial to resolve, though the hash does always look differently. |
Alternatively, the update script could use long hashes for |
@dotlambda I check master and staging currently. I'll add staging-next and python-unstable. |
acceb53
to
744ecf0
Compare
@ryantm not python-unstable, there is no guarantee that changes in there go in. |
22091c3
to
f619f4c
Compare
6b3d443
to
01c320d
Compare
ae20c97
to
edcbbe0
Compare
824b21d
to
a933c53
Compare
When I have other minor python library updates that depend on updates here, should I just push them to the branch here as well? |
Sounds like a sensible thing to do. After you're done with that, we should definitely merge this PR! |
@dotlambda you can go ahead with merging. I will add it later. |
@GrahamcOfBorg eval |
Broken by 8600798 in NixOS#49741.
Broken by e424952 in NixOS#49741.
Broken by 0fde2cf in NixOS#49741.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)