-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Staging next #49742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Staging next #49742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of packages can use it. Here is the list: - jackmix - klick - mixx - nova-filters - rhvoice - giv - mypaint - swift-im - bombono - mapnik - serf - nuitka - pyexiv2 - godot - hammer - toluapp - btanks - dxx-rebirth - endless-sky - globulation - the-powder-toy - fceux - gpsd - mongodb - rippled - mariadb - lprof
There’s nothing wrong with unstable packages when they are maintained and frequently updated. However, when they become out-of-date, as many do, it is usually best to just get rid of them as the stable version is become newer than the unstable version. This removes any packages called "unstable" that have not been updated in over 1 year. Affected packages include: - isyncUnstable - sxhkd-unstable - dosbox-unstable Revert "treewide: remove unstable packages" This reverts commit df01b0b.
This flag seems to make things work again.
Add setup-hooks for scons and waf
9 tasks
xboxdrv doesn’t use scons for installing, but instead using a makefile! Everything else is in scons so we have to keep that. I’ve added a dontUseSconsInstall flag to the scons setup-hook to skip the automatic overwrite of default “make install” call.
This gives us support for the class autoconf “./configure && make && make install” build-style.
The postInstall phase should not run postInstall itself! My mistake in renaming the old installPhase.
gsettingsschemedir only works in make where you can set any variable from the command line as in “make VAR=VAL”. Other build systems may not support this kind of loose overriding of variables. This broke a scons build here: https://hydra.nixos.org/build/84073119/
Fallout fixes from #50293
Update metadata to reflect uncompyle6 and xdis relicensing to GPL (v3 and v2 respectively)
This requires pycodestyle when using python3 and adding it leads to test failures for some reason. Maybe some patching we do. There is no reason to test codestyle for a distro, so just disable it.
These two interpreters are needed for some runtime scripts. Fixes #50570
ghc-split is a script that is written in perl. We need to have a perl interpreter around to use it. Fixes #50569
FRidh
commented
Nov 19, 2018
@@ -46,6 +46,8 @@ stdenv.mkDerivation rec { | |||
libxml2 libxslt glib gtkmm2 glibmm libsigcxx lcms boost gettext | |||
gsl poppler imagemagick libwpg librevenge | |||
libvisio libcdr libexif potrace hicolor-icon-theme | |||
|
|||
python2Env perlPackages.perl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is perl's XMLParser needed as well?
This is one of the rare times when flex is not just needed at build time. When cross compiling, we will need 2 versions of flex - one for the local system and one for the cross system.
delroth
added a commit
to delroth/nixpkgs
that referenced
this pull request
Nov 20, 2018
Regression from NixOS#49742. Invalid XML causes the manual to not build, leading to many broken derivations.
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: work-in-progress
This PR isn't done
6.topic: haskell
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: python
6.topic: stdenv
Standard environment
6.topic: xfce
The Xfce Desktop Environment
8.has: changelog
8.has: clean-up
8.has: documentation
This PR adds or changes documentation
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux: 501+
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)