Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tomcat: add purifyOnStart option (alt) #49729

Closed
wants to merge 1 commit into from
Closed

nixos/tomcat: add purifyOnStart option (alt) #49729

wants to merge 1 commit into from

Conversation

pvgoran
Copy link
Contributor

@pvgoran pvgoran commented Nov 4, 2018

With this option enabled, baseDir is mostly cleared on each startup before it's populated according to the configuration. (logs and work subdirectories are preserved.)

This prevents remainders of an old configuration (libraries, webapps, you name it) from persisting after activating a new configuration.

This is an alternative implementation of #44303, using the "whitelist" approach. (#44303 uses "blacklist" approach.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pvgoran
nixos/tomcat: add purifyOnStart option
b85760d 
With this option enabled, baseDir is mostly cleared on each startup
before it's populated according to the configuration. (`logs` and `work`
subdirectories are preserved.)

This prevents remainders of an old configuration (libraries, webapps,
you name it) from persisting after activating a new configuration.
@pvgoran pvgoran changed the title nixos/tomcat: add purifyOnStart option nixos/tomcat: add purifyOnStart option (alt) Nov 4, 2018
@pvgoran pvgoran mentioned this pull request Nov 4, 2018
Merged
9 tasks
@7c6f434c 7c6f434c closed this Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvgoran @7c6f434c @GrahamcOfBorg