ocamlPackages.checkseum: init at 0.0.3 #49733

vbgl · 2018-11-04T09:44:31Z

Motivation for this change

Needed to update the decompress and git libraries.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

vbgl · 2018-11-11T16:56:28Z

@GrahamcOfBorg build ocamlPackages.checkseum

GrahamcOfBorg · 2018-11-11T16:56:57Z

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

The full test results are available in `_build/_tests`.
Test Successful in 0.002s. 10 tests run.
installing
Processing file checkseum.install as checkseum.
post-installation fixup
moving /nix/store/6d3g3wizachqjxwnxxfxxyf44mcg573s-ocaml4.06.1-checkseum-0.0.3/doc to /nix/store/6d3g3wizachqjxwnxxfxxyf44mcg573s-ocaml4.06.1-checkseum-0.0.3/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6d3g3wizachqjxwnxxfxxyf44mcg573s-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/6d3g3wizachqjxwnxxfxxyf44mcg573s-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/6d3g3wizachqjxwnxxfxxyf44mcg573s-ocaml4.06.1-checkseum-0.0.3
/nix/store/6d3g3wizachqjxwnxxfxxyf44mcg573s-ocaml4.06.1-checkseum-0.0.3

GrahamcOfBorg · 2018-11-11T16:57:19Z

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

     SSE42(sse42);
     ^~~~~
crc32c.c:316:9: error: unknown register name '%ebx' in 'asm'
         __asm__("cpuid" \
         ^
crc32c.c:329:5: note: in expansion of macro 'SSE42'
     SSE42(sse42);
     ^~~~~
builder for '/nix/store/rvvjdaw0jm9hqhajrk1c2f835k1q9azw-ocaml4.06.1-checkseum-0.0.3.drv' failed with exit code 1
error: build of '/nix/store/rvvjdaw0jm9hqhajrk1c2f835k1q9azw-ocaml4.06.1-checkseum-0.0.3.drv' failed

GrahamcOfBorg · 2018-11-11T16:57:54Z

Success on x86_64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

shrinking /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/c/checkseum_c.cmxs
shrinking /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/laolao/laolao.cmxs
shrinking /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/bin/crc32
shrinking /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/bin/crc32c
shrinking /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/bin/adler32
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3
checking for references to /build in /nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3...
/nix/store/b2sglpb3p1xn75zx78madc1i81kk5wk4-ocaml4.06.1-checkseum-0.0.3

vbgl · 2018-11-14T06:50:40Z

@GrahamcOfBorg build ocamlPackages.checkseum

GrahamcOfBorg · 2018-11-14T06:50:59Z

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

The full test results are available in `_build/_tests`.
Test Successful in 0.002s. 10 tests run.
installing
Processing file checkseum.install as checkseum.
post-installation fixup
moving /nix/store/267la4sl9xnqg25cpb0cjxmcxmy76v6w-ocaml4.06.1-checkseum-0.0.3/doc to /nix/store/267la4sl9xnqg25cpb0cjxmcxmy76v6w-ocaml4.06.1-checkseum-0.0.3/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/267la4sl9xnqg25cpb0cjxmcxmy76v6w-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/267la4sl9xnqg25cpb0cjxmcxmy76v6w-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/267la4sl9xnqg25cpb0cjxmcxmy76v6w-ocaml4.06.1-checkseum-0.0.3
/nix/store/267la4sl9xnqg25cpb0cjxmcxmy76v6w-ocaml4.06.1-checkseum-0.0.3

GrahamcOfBorg · 2018-11-14T06:51:17Z

Success on x86_64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

shrinking /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/c/checkseum_c.cmxs
shrinking /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/laolao/laolao.cmxs
shrinking /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/bin/crc32
shrinking /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/bin/crc32c
shrinking /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/bin/adler32
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3
checking for references to /build in /nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3...
/nix/store/ywmj8k7dhzmxdx0xl27zd7wp4xi3j6d5-ocaml4.06.1-checkseum-0.0.3

GrahamcOfBorg · 2018-11-14T06:51:57Z

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/0qai8z8rq0h9s60l8177wp9wprw9zfgc-ocaml4.06.1-alcotest-0.8.2/lib
patching script interpreter paths in /nix/store/0qai8z8rq0h9s60l8177wp9wprw9zfgc-ocaml4.06.1-alcotest-0.8.2
checking for references to /build in /nix/store/0qai8z8rq0h9s60l8177wp9wprw9zfgc-ocaml4.06.1-alcotest-0.8.2...
building '/nix/store/jksfsd7bwdipsp84jq6kcns8piq93ci5-ocaml4.06.1-checkseum-0.0.3.drv'...
unpacking sources
unpacking source archive /nix/store/ll7wggm6bk1gf0r80hp8bh1r77ydh505-checkseum-v0.0.3.tbz
source root is checkseum-v0.0.3
rm: cannot remove 'src-c': No such file or directory
builder for '/nix/store/jksfsd7bwdipsp84jq6kcns8piq93ci5-ocaml4.06.1-checkseum-0.0.3.drv' failed with exit code 1
error: build of '/nix/store/jksfsd7bwdipsp84jq6kcns8piq93ci5-ocaml4.06.1-checkseum-0.0.3.drv' failed

vbgl · 2018-11-14T06:55:14Z

@GrahamcOfBorg build ocamlPackages.checkseum

GrahamcOfBorg · 2018-11-14T06:55:32Z

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

                 ^^^^^^^^^^^
Error: Library "checkseum.c" not found.
Hint: try: dune external-lib-deps --missing @@default
File "bin/dune", line 11, characters 12-23:
11 |  (libraries checkseum.c common rresult fmt cmdliner))
                 ^^^^^^^^^^^
Error: Library "checkseum.c" not found.
Hint: try: dune external-lib-deps --missing @@default
builder for '/nix/store/7acqs539gclcpgvy8k46b17nm47jcgry-ocaml4.06.1-checkseum-0.0.3.drv' failed with exit code 1
error: build of '/nix/store/7acqs539gclcpgvy8k46b17nm47jcgry-ocaml4.06.1-checkseum-0.0.3.drv' failed

GrahamcOfBorg · 2018-11-14T06:55:37Z

Success on x86_64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/stublibs/dlllaolao_stubs.so
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/ocaml/checkseum_ocaml.cmxs
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/checkseum.cmxs
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/c/checkseum_c.cmxs
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/laolao/laolao.cmxs
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3
checking for references to /build in /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3...
/nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3

GrahamcOfBorg · 2018-11-14T06:55:47Z

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

The full test results are available in `_build/_tests`.
Test Successful in 0.002s. 10 tests run.
installing
Processing file checkseum.install as checkseum.
post-installation fixup
moving /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/doc to /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3
/nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3

vbgl · 2018-11-14T07:03:33Z

@GrahamcOfBorg build ocamlPackages.checkseum

GrahamcOfBorg · 2018-11-14T07:03:46Z

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

The full test results are available in `_build/_tests`.
Test Successful in 0.002s. 10 tests run.
installing
Processing file checkseum.install as checkseum.
post-installation fixup
moving /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/doc to /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/share/doc
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3
/nix/store/dz61yxip9xz5li6mx6yajq17r31iwvp7-ocaml4.06.1-checkseum-0.0.3

GrahamcOfBorg · 2018-11-14T07:03:49Z

Success on aarch64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

post-installation fixup
moving /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3/doc to /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3
shrinking /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/ocaml/checkseum_ocaml.cmxs
shrinking /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/checkseum.cmxs
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3/lib
patching script interpreter paths in /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3
checking for references to /build in /nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3...
/nix/store/hqbsq0i2wf3mrxiywxd1w92f4x3aa6cd-ocaml4.06.1-checkseum-0.0.3

GrahamcOfBorg · 2018-11-14T07:03:54Z

Success on x86_64-linux (full log)

Attempted: ocamlPackages.checkseum

Partial log (click to expand)

shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/checkseum.cmxs
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib/ocaml/4.06.1/site-lib/checkseum/ocaml/checkseum_ocaml.cmxs
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/bin/crc32c
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/bin/adler32
shrinking /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/bin/crc32
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/lib  /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3/bin
patching script interpreter paths in /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3
checking for references to /build in /nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3...
/nix/store/4h9wqppcqwk5vb8vsxc09ss8ms8ad9b7-ocaml4.06.1-checkseum-0.0.3

Mic92 · 2018-11-14T19:06:26Z

pkgs/development/ocaml-modules/checkseum/default.nix

+  postPatch = stdenv.lib.optionalString (!hasC) ''
+    rm -r bin src-c
+  '';
+
  buildInputs = [ ocaml findlib dune alcotest cmdliner fmt rresult ];
  propagatedBuildInputs = [ optint ];

  buildPhase = "dune build";


buildDunePackage?

Mic92 · 2018-11-14T19:06:51Z

pkgs/development/ocaml-modules/optint/default.nix

+
+  buildInputs = [ ocaml findlib dune ];
+
+  buildPhase = "dune build";


This library provide one module Optint which internally uses an int if you are in a x64 architecture or an int32 (boxed value) if you are in a x86 architecture. Homepage: https://github.com/mirage/optint

Chekseum is an OCaml library which implements ADLER-32 and CRC32C Cyclic Redundancy Check. It provides 2 implementation, the first in C and the second in OCaml. Homepage: https://github.com/mirage/checkseum

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 4, 2018

vbgl added 8.has: package (new) 6.topic: ocaml labels Nov 4, 2018

vbgl force-pushed the ocaml-checkseum-0.0.3 branch from 03975ca to dd91220 Compare November 14, 2018 06:37

vbgl force-pushed the ocaml-checkseum-0.0.3 branch from dd91220 to d1d0b57 Compare November 14, 2018 06:55

vbgl force-pushed the ocaml-checkseum-0.0.3 branch from d1d0b57 to 0ffd98a Compare November 14, 2018 07:03

Mic92 reviewed Nov 14, 2018

View reviewed changes

pkgs/development/ocaml-modules/optint/default.nix

buildInputs = [ ocaml findlib dune ];

buildPhase = "dune build";

Copy link

Member

Mic92 Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too.

vbgl added 2 commits December 11, 2018 07:45

ocamlPackages.optint: init at 0.0.2

8767fd3

This library provide one module Optint which internally uses an int if you are in a x64 architecture or an int32 (boxed value) if you are in a x86 architecture. Homepage: https://github.com/mirage/optint

ocamlPackages.checkseum: init at 0.0.3

5204351

Chekseum is an OCaml library which implements ADLER-32 and CRC32C Cyclic Redundancy Check. It provides 2 implementation, the first in C and the second in OCaml. Homepage: https://github.com/mirage/checkseum

vbgl force-pushed the ocaml-checkseum-0.0.3 branch from 0ffd98a to 5204351 Compare December 11, 2018 07:50

vbgl merged commit 1a04bd4 into NixOS:master Dec 11, 2018

vbgl deleted the ocaml-checkseum-0.0.3 branch December 11, 2018 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ocamlPackages.checkseum: init at 0.0.3 #49733

ocamlPackages.checkseum: init at 0.0.3 #49733

vbgl commented Nov 4, 2018

vbgl commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

vbgl commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

vbgl commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

vbgl commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

Mic92 Nov 14, 2018

Mic92 Nov 14, 2018


		buildInputs = [ ocaml findlib dune ];

		buildPhase = "dune build";

ocamlPackages.checkseum: init at 0.0.3 #49733

ocamlPackages.checkseum: init at 0.0.3 #49733

Conversation

vbgl commented Nov 4, 2018

Motivation for this change

Things done

vbgl commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

GrahamcOfBorg commented Nov 11, 2018

vbgl commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

vbgl commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

vbgl commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

GrahamcOfBorg commented Nov 14, 2018

Mic92 Nov 14, 2018

Choose a reason for hiding this comment

Mic92 Nov 14, 2018

Choose a reason for hiding this comment