Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrootenv: strip the binary #49725

Merged
merged 2 commits into from Nov 5, 2018
Merged

chrootenv: strip the binary #49725

merged 2 commits into from Nov 5, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 4, 2018

Motivation for this change

Get rid of references to the full compiler package from the runtime closure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Not sure how to test this directly as chrootenv is not publicly exposed AFAIK. Tested indirectly as part of steam.

/cc maintainer @yegortimoshenko

@pbogdan
Copy link
Member Author

pbogdan commented Nov 4, 2018

I'm confused by the rebuild amount - is Hydra now building unfree software?

lukateras
lukateras reviewed Nov 4, 2018
View reviewed changes
pkgs/build-support/build-fhs-userenv/chrootenv/default.nix
meta = with stdenv.lib; {
description = "Setup mount/user namespace for FHS emulation";
license = licenses.free;
license = licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is, Nixpkgs license.

@lukateras
Copy link
Member

Thanks for the catch! This really shouldn't override default phases. I've pushed a commit that uses Meson to build the project. Meaning, no custom phases are necessary at all. What do you think?

cc @abbradar, @jtojnar

@pbogdan
Copy link
Member Author

pbogdan commented Nov 5, 2018

LGTM, thanks!

@lukateras lukateras merged commit 77dad17 into NixOS:master Nov 5, 2018
@pbogdan pbogdan deleted the chrootenv-strip branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras left review comments

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @lukateras @jtojnar @GrahamcOfBorg