Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: programs.bash: Fix comment about completion #49746

Merged
merged 1 commit into from Nov 4, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 4, 2018

Motivation for this change

XDG_DATA_DIRS already includes what is typically the share directory.
Adding an extra share breaks it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

`XDG_DATA_DIRS` already includes what is typically the `share` directory.
Adding an extra `share` breaks it.
@roberth
Copy link
Member Author

roberth commented Nov 4, 2018

Related to #26031

@roberth roberth merged commit 2adb521 into master Nov 4, 2018
@veprbl veprbl deleted the fix-nixos-bash-completion-comment branch December 14, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants