Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-gitlab: init at 1.6.0 #49744

Merged
merged 2 commits into from Nov 4, 2018
Merged

pythonPackages.python-gitlab: init at 1.6.0 #49744

merged 2 commits into from Nov 4, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 4, 2018 •
edited

Motivation for this change

Python lib to access GitLab API

I had to pull httmock from GitHub because the tests where not included on PyPi

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.python-gitlab python3.pkgs.python-gitlab

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.python-gitlab, python3.pkgs.python-gitlab

Partial log (click to expand)

test_all (gitlab.tests.test_types.TestGitlabAttribute) ... ok
test_empty_input (gitlab.tests.test_types.TestListAttribute) ... ok
test_get_for_api (gitlab.tests.test_types.TestListAttribute) ... ok
test_list_input (gitlab.tests.test_types.TestListAttribute) ... ok
test_get_for_api (gitlab.tests.test_types.TestLowercaseStringAttribute) ... ok

----------------------------------------------------------------------
Ran 88 tests in 0.421s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.python-gitlab, python3.pkgs.python-gitlab

Partial log (click to expand)

test_invalid_data (gitlab.tests.test_config.TestConfigParser) ... ok
test_invalid_id (gitlab.tests.test_config.TestConfigParser) ... ok
test_valid_data (gitlab.tests.test_config.TestConfigParser) ... ok

----------------------------------------------------------------------
Ran 88 tests in 0.858s

OK
/nix/store/82i34vjc4g0bsnl2dl6a9w5mazd79w1f-python2.7-python-gitlab-1.6.0
/nix/store/f1my8q4128g4j2gdib6qd1kv7px85sbq-python3.6-python-gitlab-1.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.python-gitlab, python3.pkgs.python-gitlab

Partial log (click to expand)

test_invalid_data (gitlab.tests.test_config.TestConfigParser) ... ok
test_invalid_id (gitlab.tests.test_config.TestConfigParser) ... ok
test_valid_data (gitlab.tests.test_config.TestConfigParser) ... ok

----------------------------------------------------------------------
Ran 88 tests in 0.418s

OK
/nix/store/h72mf91j6pam7s47jr6gwfzqwh4xi6lp-python2.7-python-gitlab-1.6.0
/nix/store/gl51laplqv2dx9d6qgb680pf7ws85vi5-python3.6-python-gitlab-1.6.0

@dotlambda dotlambda changed the title Python gitlab: init at 1.6.0 pythonPackages.python-gitlab: init at 1.6.0 Nov 4, 2018
@dotlambda dotlambda merged commit 6a73df7 into NixOS:master Nov 4, 2018
@nyanloutre nyanloutre deleted the python-gitlab branch November 20, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @dotlambda @GrahamcOfBorg