Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc-8.2.1-binary: Patch shebang causing failures in Centos 6 #49698

Merged
merged 1 commit into from Nov 4, 2018
Merged

ghc-8.2.1-binary: Patch shebang causing failures in Centos 6 #49698

merged 1 commit into from Nov 4, 2018

Conversation

unode
Copy link
Member

@unode unode commented Nov 3, 2018

Motivation for this change

On Centos 6, when building from source the system shell would be used causing glibc reference problems.

...
cannot find section .interp
cannot find section .interp
cannot find section .interp
cannot find section .interp
cannot find section .interp
not an ELF executable
not an ELF executable
missing ELF header
not an ELF executable
cannot find section .interp
file ./ghc-8.2.1/ghc/stage2/build/tmp/ghc-stage2 had a PT_GNU_STACK program header, converted
setting SOURCE_DATE_EPOCH to timestamp 1500679444 of file ghc-8.2.1/configure
patching sources
configuring
configure flags: --prefix=/share/nix/store/6gvgr6m1rclbm9q9dah623awc263qzxp-ghc-8.2.1-binary --with-gmp-libraries=/share/nix/store/c5dw1yv0jkyf2p35scnl07lipdz1y2sv-gmp-6.1.2/lib --with-gmp-includes=/share/nix/store/kmwwwq5c0b8wdq6pw5x3b7sl8xzswj1-gmp-6.1.2-dev/include
/bin/sh: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /share/nix/store/p0sdx09s2nk9js3f914660x1l9smlcbk-ncurses-6.1-abi5-compat/lib/libtinfo.so.5)
/bin/sh: /lib64/libc.so.6: version `GLIBC_2.16' not found (required by /share/nix/store/p0sdx09s2nk9js3f914660x1l9smlcbk-ncurses-6.1-abi5-compat/lib/libtinfo.so.5)
builder for ‘/share/nix/store/b4b7d0d4zfmqkqsh1ydc4cmchzqk9vy5-ghc-8.2.1-binary.drv’ failed with exit code 1
cannot build derivation ‘/share/nix/store/r9vi05vlgmbly78wvynh4mdyhyz0998w-ghc-8.4.3.drv’: 1 dependencies couldn't be built
error: build of ‘/share/nix/store/r9vi05vlgmbly78wvynh4mdyhyz0998w-ghc-8.4.3.drv’ failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

peti
peti requested changes Nov 3, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target the haskell-updates branch with this PR.

@Ericson2314
Copy link
Member

Can we do this to the other binary GHC too?

@unode unode changed the base branch from master to haskell-updates November 3, 2018 20:39
@unode
Copy link
Member Author

unode commented Nov 3, 2018

@peti done

@Ericson2314 Seems like it was done before https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/ghc/7.10.3-binary.nix#L68

@unode
Copy link
Member Author

unode commented Nov 3, 2018 •
edited

Original issue for ghc-7 #40691.
Interesting convergence. Same fix though I was not aware of the other patch.

@unode
Copy link
Member Author

unode commented Nov 3, 2018

Now properly rebased on haskell-updates.

@Ericson2314
Copy link
Member

Hehe I don't blame you. The other person should have patched all of them for the same reasons! (Or, we should abstract these would there's nothing to forget...)

@peti peti merged this pull request into NixOS:haskell-updates Nov 4, 2018
@unode unode deleted the patch-1 branch November 4, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@unode @Ericson2314 @peti @GrahamcOfBorg