Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RStudio 1.2 preview init #49701

Merged
merged 2 commits into from Nov 4, 2018
Merged

RStudio 1.2 preview init #49701

merged 2 commits into from Nov 4, 2018

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Nov 3, 2018

Motivation for this change
  • preview hasn't been released in a long time
  • working clang/completion
  • could potentially be merged to default and deleted once a release happens
  • there are no regular tags or available version numbers on the public repo, so this isn't technically equivalent to any preview "release" binary that could be downloaded.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peti
Copy link
Member

peti commented Nov 3, 2018

@GrahamcOfBorg build rstudio-preview

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rstudio-preview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rstudio-preview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rstudio-preview

Partial log (click to expand)

/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/r-ldpath: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/rstudio-backtrace.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/postback/askpass-passthrough: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/postback/rpostback-editfile: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/postback/rpostback-gitssh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/postback/rpostback-askpass: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1/bin/postback/rpostback-pdfviewer: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1...
postPatchMkspecs
/nix/store/rxldjgjix0bjn1hxz8qkyb8ik3qrds2n-RStudio-preview-f33fb2b2f1

@peti peti merged commit 4a7cdf4 into NixOS:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants