nixos/prometheus: check configuration before activating, allow specifying custom prometheus package #49749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a package option we can let the user decide what package to use for prometheus without requiring an overlay.
With `promtool` we can check the validity of a configuration before deploying it. This avoids situations where you would end up with a broken monitoring system without noticing it - since the monitoring broke down. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
After running into an issue were I deployed a broken prometheus configuration & broken rules I started adding a check in my nixops configuration to verify files before they are being deployed.
It makes sense to me to do this at all times since it provides a nice additional layer of safeguards against breaking your own systems (monitoring).
I also introduced the
services.prometheus.packageoption to allow overriding the default package that is being used without an overlay.cc @ocharles @fpletz @bjornfor @teh
Things done
sandboxinnix.confon non-NixOS)