Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: fix build on darwin #49694

Merged
merged 1 commit into from Nov 3, 2018
Merged

alacritty: fix build on darwin #49694

merged 1 commit into from Nov 3, 2018

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Nov 3, 2018

Motivation for this change

Solves #49693

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Nov 3, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 3, 2018

@GrahamcOfBorg build alacritty

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: alacritty

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alacritty

Partial log (click to expand)

these paths will be fetched (5.58 MiB download, 34.43 MiB unpacked):
  /nix/store/bd9ny3y2m3z375gpkycj97q2f6wc12d8-alacritty-unstable-0.2.1-terminfo
  /nix/store/h7vkcnfy76acf38f0znn3pd7mbmhv9k3-alacritty-unstable-0.2.1
  /nix/store/kvadmbyjd8lg86rz29b1w8n7vzhd9akn-xclip-0.13
copying path '/nix/store/bd9ny3y2m3z375gpkycj97q2f6wc12d8-alacritty-unstable-0.2.1-terminfo' from 'https://cache.nixos.org'...
copying path '/nix/store/kvadmbyjd8lg86rz29b1w8n7vzhd9akn-xclip-0.13' from 'https://cache.nixos.org'...
copying path '/nix/store/h7vkcnfy76acf38f0znn3pd7mbmhv9k3-alacritty-unstable-0.2.1' from 'https://cache.nixos.org'...
/nix/store/h7vkcnfy76acf38f0znn3pd7mbmhv9k3-alacritty-unstable-0.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: alacritty

Partial log (click to expand)

Created 'Alacritty.app' in 'target/release/osx'
installing
post-installation fixup
gzipping man pages under /nix/store/lmv2l5smgkc3c1rwrgsl23hr69vv4dji-alacritty-unstable-0.2.1/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lmv2l5smgkc3c1rwrgsl23hr69vv4dji-alacritty-unstable-0.2.1/bin
patching script interpreter paths in /nix/store/lmv2l5smgkc3c1rwrgsl23hr69vv4dji-alacritty-unstable-0.2.1
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/yph1xg8ky29k3g3b0wmsw39xfk9xy7xk-alacritty-unstable-0.2.1-terminfo
/nix/store/lmv2l5smgkc3c1rwrgsl23hr69vv4dji-alacritty-unstable-0.2.1

@Mic92 Mic92 merged commit 330afca into NixOS:master Nov 3, 2018
@periklis periklis deleted the alacritty-fix-regression branch November 3, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @Mic92 @GrahamcOfBorg