Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timescaledb: (0.11.0 -> 1.0.0) #49695

Closed
wants to merge 1 commit into from
Closed

timescaledb: (0.11.0 -> 1.0.0) #49695

wants to merge 1 commit into from

Conversation

svenklemm
Copy link

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@svenklemm
timescaledb: (0.11.0 -> 1.0.0)
33fcc77 
Update timescaledb to latest version. Fix license information.
@thoughtpolice
Copy link
Member

thoughtpolice commented Nov 3, 2018 •
edited

Mmmm, I have a bunch of changes incoming soon enough for Postgres including a timescale update, but they'll have to go through staging first, so they'll be somewhat delayed. I can merge this (and maybe a few other updates) in the mean time and rebase though, I suppose...

Do you also need this on release-18.09 by chance?

@thoughtpolice
Copy link
Member

Oh dear, I'm sorry. I actually did a small set of updates to a number of packages including timescaledb and I completely forgot to pull your change instead since you did it and used my own (that I wrote privately yesterday). Therefore, this was fixed in a713251, but I didn't give you credit for the change. Sorry about that. :(

@svenklemm
Copy link
Author

No problem, as long as the version got updated :)
You didnt update the license though. TimescaleDB is Apache 2 and not PostgreSQL licensed.

@thoughtpolice
Copy link
Member

Ah damn, you're right. Must have been a copy-paste error. I'll fix that, too.

@thoughtpolice
Copy link
Member

thoughtpolice commented Nov 4, 2018 •
edited

b0f7c86 (master) and cc39474 (release-18.09) for the license change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svenklemm @thoughtpolice @GrahamcOfBorg @Janik-Haag