Skip to content

networkmanager-l2tp: hoist pname attribute #49731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

networkmanager-l2tp: hoist pname attribute #49731

wants to merge 1 commit into from
+3 −2

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 4, 2018

Motivation for this change

Since #49398 was merged, name should have pname as a suffix, however
this derivation adds '-gnome' as a suffix when it is built with GNOME
support. This change makes the derivation more similar to some other
Network Manager plugins, where pname is not an attribute.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@danieldk
networkmanager-l2tp: hoist pname attribute
e447039 
Since NixOS#49398 was merged, name should have pname as a suffix, however
this derivation adds '-gnome' as a suffix when it is built with GNOME
support. This change makes the derivation more similar to some other
Network Manager plugins, where pname is not an attribute.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 4, 2018 •
edited
Loading

#49398 was reverted until we have a fix for all evaluation errors.

@danieldk
Copy link
Contributor Author

danieldk commented Nov 4, 2018

@Mic92 indeed, I'll close this.

@danieldk danieldk closed this Nov 4, 2018
@danieldk danieldk deleted the nm-l2tp branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @Mic92 @GrahamcOfBorg