Set CMAKE_SYSTEM_* for cross compiling #48602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses uname data to find what to set these variables: - CMAKE_SYSTEM_NAME - CMAKE_SYSTEM_PROCESSOR - CMAKE_SYSTEM_VERSION - CMAKE_HOST_SYSTEM_NAME - CMAKE_HOST_SYSTEM_PROCESSOR - CMAKE_HOST_SYSTEM_VERSION
the boost url is broken - remove for now
this makes it easier to show what supports windows vs. unix.
"platforms.all" could include any possible os (even a machine with no OS at all!). We can’t possible hope to support all of that, so need to be more specific.
GrahamcOfBorg
added
6.topic: stdenv
|
Success on aarch64-linux (full log) Attempted: boost, sqlite Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: boost, sqlite Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: boost, sqlite Partial log (click to expand)
|
|
@GrahamcOfBorg build pkgs.pkgsCross.mingwW64.brotli |
|
Success on aarch64-linux (full log) Attempted: pkgs.pkgsCross.mingwW64.brotli Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pkgs.pkgsCross.mingwW64.brotli Partial log (click to expand)
|
avoid mass rebuild from the last commits
|
@Ericson2314 This avoids having to create a wrapper for Cmake and should work just as good... Does it look right to you? |
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
labels
|
Success on aarch64-linux (full log) Attempted: boost, sqlite Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: boost, sqlite Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: pkgs.pkgsCross.mingwW64.brotli Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: boost, sqlite Partial log (click to expand)
|
configure spits out an error when running on windows
only static will build for me
|
Failure on aarch64-linux (full log) Attempted: pkgsCross.mingwW64.nix Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: pkgsCross.mingwW64.nix Partial log (click to expand)
|
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
@GrahamcOfBorg build pkgsCross.mingwW64.nix |
|
Success on aarch64-linux (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: pkgsCross.mingwW64.nix Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: pkgsCross.mingwW64.nix Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: pkgsCross.mingwW64.nix Partial log (click to expand)
|
mingw is the toolchain name but it is actually run on a window kernel
|
Failure on x86_64-linux (full log) Attempted: pkgsCross.mingwW64.nix Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Awesome!! Small nit, the "doubles" changes can be tested in I was about to mention CC @aneeshusa, let's use your nix-level hook for this next! (And also merge your cmake changes that use it :) ) |
these weren’t being run correctly
|
Success on aarch64-linux (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Oh, even more awesome. Thanks @matthewbauer! |
Ericson2314
approved these changes
Oct 18, 2018
|
Success on x86_64-darwin (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: boost, c-ares, curl, nghttp2, sqlite, zlib Partial log (click to expand)
|
globin
pushed a commit
to mayflower/nixpkgs
that referenced
this pull request
Nov 20, 2018
Set CMAKE_SYSTEM_* for cross compiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This sets some new variables in make-derivation for cross compiling with CMAKE. Here is the list:
To do this, we need to start keeping track of uname values, respectively:
We don't really have a way to get the last one, so leave it null for now.
Also remove some old hacks setting CMAKE_SYSTEM_NAME ad-hoc. And also add some windows doubles (were strangely missing).