rambox: fix incorrect sha256 #48606
Closed
rambox: fix incorrect sha256 #48606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/NixOS/nixpkgs: (554 commits) generators: make toPretty handle floats correctly haskell-yesod-core: disable broken test suite git-annex: update sha256 hash for the new 6.20181011 version cabal2nix: update overrides for latest yaml version hackage-packages.nix: automatic Haskell package set update hackage2nix: disable failing Hydra builds LTS Haskell 12.13 saga: add mpickering as a co-maintainer after NixOS#39125 python3Packages.cmd2: 0.9.4 -> 0.9.6 ghc: add new 8.4.4 version apvlv: add .desktop file staruml: fix download URL spectmorph: init at 0.4.1 termdown: 1.11.0 -> 1.14.1 (NixOS#48443) gotop: 1.2.9 -> 1.5.0 (NixOS#48407) emacs-mac: use generic builder dolphin-emu: fix metadata (GPLv2 -> GPLv2+, http -> https) tests/prometheus-exporters: add new Tor exporter dbeaver: 5.2.1 -> 5.2.2 nixos/hardened: add myself to maintainers ...
* 'master' of https://github.com/NixOS/nixpkgs: (104 commits) python3.pkgs.pyls: 0.2.1 -> 0.3.0 chromium: fix aarch64 build (NixOS#48586) pythonPackages.cligj: 0.4.0 -> 0.5.0 (NixOS#48584) Flexget: 2.15.1 -> 2.16.2 (NixOS#48583) gitolite 3.6.7 -> 3.6.10 (NixOS#48562) oh-my-zsh: 2018-09-03 -> 2018-09-14 julia_10: update to 1.0.1 signal-desktop: 1.16.2 -> 1.16.3 Revert "Merge pull request NixOS#48122 from zimbatm/pkg-nixos-rebuild" terraform-providers.libvirt: fix plugin output (NixOS#48577) libssh: 0.7.5 -> 0.7.6 googler: 3.7 -> 3.7.1 (NixOS#48508) chromium plugins: add meta.platforms (NixOS#48495) varnish6: 6.0.1 -> 6.1.0 (NixOS#48487) erlangR21: 21.0 -> 21.1.1 (NixOS#47371) varnish4: 4.1.9 -> 4.1.10 (NixOS#48488) tmux: 2.7 -> 2.8 nixpart0.blivet: fix reference to selinux python modules blivet: fix reference to selinux python modules magit-filenotify: Fix missing dependency on git ...
|
It seems some other commits sneaked their way in here. Also, do you know why the sha256 changed? Perhaps we also need to fix the download URL or something to avoid this happening again. Edit: just saw that it's fetchNodeModules. Not sure how to deal with this, but just updating the sha256 whenever it breaks almost certainly isn't a good approach… |
|
This is bad it could mean that the npm fixed input derivation is not reproducible, cc @yegortimoshenko |
|
Cherry-picked here: 4051fc9 |
|
backport: ff7413b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)