Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group the release info #48588

Merged
merged 1 commit into from Nov 16, 2018
Merged

group the release info #48588

merged 1 commit into from Nov 16, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 16, 2018

Motivation for this change

this makes the codename globally accessible in the repo. The release is
not only for NixOS anymore.

continuation on #48122

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm mentioned this pull request Oct 16, 2018
Merged
9 tasks
samueldr
samueldr reviewed Oct 16, 2018
View reviewed changes
release-info.nix Outdated Show resolved Hide resolved
samueldr
samueldr reviewed Oct 16, 2018
View reviewed changes
lib/trivial.nix Outdated Show resolved Hide resolved
edolstra
edolstra reviewed Oct 17, 2018
View reviewed changes
lib/trivial.nix Outdated Show resolved Hide resolved
@zimbatm
group the release info
2a838cb 
this makes the codename globally accessible in the repo. The release is
not only for NixOS anymore.
@zimbatm
Copy link
Member Author

zimbatm commented Nov 15, 2018

simplified the PR to the minimum, hope that won't be controversial.

@edolstra edolstra merged commit 304e14a into NixOS:master Nov 16, 2018
@samueldr samueldr mentioned this pull request Nov 16, 2018
Merged
@zimbatm zimbatm deleted the shared-codename branch November 16, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

@edolstra edolstra edolstra left review comments

@infinisil infinisil infinisil approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zimbatm @samueldr @edolstra @infinisil @GrahamcOfBorg