speedtest-cli: move to pythonPackages, add to home-assistant #48596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makefu
changed the title
|
@GrahamcOfBorg build python3Packages.speedtest-cli |
|
Success on x86_64-linux (full log) Attempted: python3Packages.speedtest-cli Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python3Packages.speedtest-cli Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: python3Packages.speedtest-cli Partial log (click to expand)
|
|
This installs two separate executables in |
|
Success on x86_64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: home-assistant Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
|
Cc @dotlambda |
|
I thought I had seen this package before. This is a duplicate of https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/networking/speedtest-cli/default.nix That package has the same issue of having two commands in |
|
Basically the current package should be moved into the python-modules hierarchy and be updated to use fetchPypi. Then we can add a reference in all packages like |
|
ah, that was the reason why it was not detected by home-assistant, i have no idea about the wrapper or the cli thingy. |
|
|
|
https://github.com/sivel/speedtest-cli/blob/master/setup.py#L70-L74 look like the lines responsible for the two commands. |
makefu
force-pushed
the
pkgs/pythonPackages.speedtest-cli/init
branch
from
666acea
to
b03ed9c
Compare
|
@peterhoeg i've add a postInstall phase |
makefu
force-pushed
the
pkgs/pythonPackages.speedtest-cli/init
branch
from
acd2de8
to
3511e52
Compare
makefu
changed the title
|
Success on x86_64-darwin (full log) Attempted: home-assistant, speedtest-cli Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: home-assistant, speedtest-cli Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: home-assistant, speedtest-cli Partial log (click to expand)
|
dotlambda
requested changes
Oct 17, 2018
pkgs/top-level/all-packages.nix
Outdated
| @@ -8784,7 +8784,7 @@ with pkgs; | |||
|
|
|||
| sparse = callPackage ../development/tools/analysis/sparse { }; | |||
|
|
|||
| speedtest-cli = callPackage ../tools/networking/speedtest-cli { }; | |||
| speedtest-cli = with pythonPackages; toPythonApplication speedtest-cli; | |||
There was a problem hiding this comment.
Suggested change
| speedtest-cli = with pythonPackages; toPythonApplication speedtest-cli; | |
| speedtest-cli = with python3Packages; toPythonApplication speedtest-cli; |
There was a problem hiding this comment.
Suggested change
| speedtest-cli = with pythonPackages; toPythonApplication speedtest-cli; | |
| speedtest-cli = with pythonPackages; toPythonApplication speedtest-cli; |
i had this before, but i thought that pinning to python3 would be the wrong thing to do here. The tool works with both python2 and python3, my guess was that pythonPackages may change to python3Packages sometime in the future
There was a problem hiding this comment.
No, it won't since python will probably never refer to python3. See #18185.
makefu
force-pushed
the
pkgs/pythonPackages.speedtest-cli/init
branch
from
3511e52
to
f0c643a
Compare
|
Success on x86_64-darwin (full log) Attempted: home-assistant, speedtest-cli Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: home-assistant, speedtest-cli Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: home-assistant, speedtest-cli Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Be able to use the speedtest component in home-assistant
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)