Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 9617a043541d
Choose a base ref
...
head repository: NixOS/nix
compare: bd78544f66a0
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 16, 2018

  1. Get rid of UDSRemoteStore::Connection 

    Since its superclass RemoteStore::Connection contains 'to' and 'from'
fields that refer to the file descriptor maintained in the subclass,
it was possible for the flush() call in Connection::~Connection() to
write to a closed file descriptor (or worse, a file descriptor now
referencing another file). So make sure that the file descriptor
survives 'to' and 'from'.
    @edolstra
    edolstra committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    ba51100 View commit details
    Browse the repository at this point in the history

  2. RemoteStore: Close connection if an exception occurs 

    Fixes #2075.
    @edolstra
    edolstra committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    79e358c View commit details
    Browse the repository at this point in the history

  3. Fix assertion failure in Store::queryPathInfo() 

      $ nix-store -qR /nix/store/fnord
  nix-store: src/libstore/store-api.cc:80: std::__cxx11::string nix::storePathToHash(const Path&): Assertion `base.size() >= storePathHashLen' failed.
  Aborted
    @edolstra
    edolstra committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    bd78544 View commit details
    Browse the repository at this point in the history