Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lirc: add support for Python bindings #48603

Merged
merged 1 commit into from Oct 17, 2018
Merged

lirc: add support for Python bindings #48603

merged 1 commit into from Oct 17, 2018

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

LIRC has Python bindings, but they are currently not supported in Nix.

Things done

This PR uses toPythonModule to create a Python package from lirc. It also applies a patch, which has been submitted upstream but not yet merged, that fixes two bugs in the Python bindings.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 17, 2018

@GrahamcOfBorg build python3.pkgs.lirc

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python3.pkgs.lirc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.lirc

Partial log (click to expand)

shrinking /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/lib/liblirc_driver.so.0.3.0
shrinking /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/lib/liblirc_client.so.0.6.0
shrinking /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/lib/liblirc.so.0.0.0
gzipping man pages under /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/lib  /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/bin  /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/sbin
patching script interpreter paths in /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1
checking for references to /build in /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1...
moving /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/sbin/* to /nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1/bin
/nix/store/652pssndrb45pyccy43bpbfl7nzplz1i-lirc-0.10.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.lirc

Partial log (click to expand)

shrinking /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/sbin/lirc-lsplugins
shrinking /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/sbin/lircd
shrinking /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/sbin/lircmd
gzipping man pages under /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/lib  /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/bin  /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/sbin
patching script interpreter paths in /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1
checking for references to /build in /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1...
moving /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/sbin/* to /nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1/bin
/nix/store/860cwlbk7jrblxwrdcjq9y9bzpfxb8gg-lirc-0.10.1

@FRidh FRidh merged commit 3055a0c into NixOS:master Oct 17, 2018
@lopsided98 lopsided98 deleted the lirc-python branch October 21, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @FRidh @GrahamcOfBorg