pythonPackages.python-packer: init at 0.1.2 #48592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
reviewed
Oct 16, 2018
| #checkInputs = [ tox ]; | ||
| #checkPhase = '' | ||
| # tox | ||
| #''; |
There was a problem hiding this comment.
as it's questionable if we'll ever get to run these tests (due to the obvious impurity) I guess that we could simply remove this code rather than commenting it.
There was a problem hiding this comment.
@Ma27 I thought it may come in use. so i just kept it for reference. Ill remove if that's really necessary?
There was a problem hiding this comment.
I personally think that this is merely some sort of visual overhead in the derivation, adding support for tests to a derivation is a fairly common task, so documenting (as you did) above doCheck = false; for the reasons should be sufficient IMHO.
There was a problem hiding this comment.
remove it. We won't ever use tox anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)