Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polar-bookshelf: init at 1.0.11 #48610

Merged
merged 9 commits into from
Nov 7, 2018
Merged

polar-bookshelf: init at 1.0.11 #48610

merged 9 commits into from
Nov 7, 2018
+89 −0

Conversation

fx-chun
Copy link
Member

@fx-chun fx-chun commented Oct 17, 2018 •
edited
Loading

Motivation for this change

Addition of polar-bookshelf, an application for document annotation and storage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 17, 2018
@fx-chun fx-chun changed the title polar-bookshelf: init at 1.0.2 polar-bookshelf: init at 1.0.4 Oct 24, 2018
@fx-chun fx-chun force-pushed the init/polar-bookshelf branch from 61a92a3 to 8d5cd34 Compare October 24, 2018 16:54
@fx-chun
Copy link
Member Author

fx-chun commented Oct 24, 2018

@FRidh

c0bw3b
c0bw3b requested changes Nov 3, 2018
View reviewed changes
@fx-chun fx-chun changed the title polar-bookshelf: init at 1.0.4 polar-bookshelf: init at 1.0.11 Nov 7, 2018
@c0bw3b c0bw3b merged commit 7ea48e1 into NixOS:master Nov 7, 2018
@c0bw3b c0bw3b mentioned this pull request Nov 17, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@FRidh FRidh

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fx-chun @Mic92 @FRidh @c0bw3b @GrahamcOfBorg