Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-prompt: init at 1.0.4 #48614

Merged
merged 1 commit into from Oct 23, 2018
Merged

kube-prompt: init at 1.0.4 #48614

merged 1 commit into from Oct 23, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 17, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Init kube-prompt: "An interactive kubernetes client featuring auto-complete using go-prompt."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Oct 19, 2018
View reviewed changes
pkgs/development/tools/kube-prompt/default.nix Outdated
goDeps = ./deps.nix;

meta = {
description = "An interactive kubernetes client featuring auto-complete using go-prompt.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the dot at the end of the description line.

pkgs/development/tools/kube-prompt/default.nix Outdated
@@ -0,0 +1,25 @@
{ stdenv, lib, buildGoPackage, fetchFromGitHub }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdenv is not used.

Mic92
Mic92 reviewed Oct 21, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -8571,6 +8571,8 @@ with pkgs;

kubectx = callPackage ../development/tools/kubectx { };

kube-prombt = callPackage ../development/tools/kube-prompt { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kube-prombt = callPackage ../development/tools/kube-prompt { };
kube-prompt = callPackage ../development/tools/kube-prompt { };

@vdemeester
kube-prompt: init at 1.0.4
10e0298 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@nlewo
Copy link
Member

nlewo commented Oct 23, 2018

@GrahamcOfBorg build kube-prompt

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kube-prompt

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sbklb7hf1f9sjpv2xaxnxr8cf02fxy7k-kube-prompt-1.0.4-bin
shrinking /nix/store/sbklb7hf1f9sjpv2xaxnxr8cf02fxy7k-kube-prompt-1.0.4-bin/bin/kube-prompt
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sbklb7hf1f9sjpv2xaxnxr8cf02fxy7k-kube-prompt-1.0.4-bin/bin
patching script interpreter paths in /nix/store/sbklb7hf1f9sjpv2xaxnxr8cf02fxy7k-kube-prompt-1.0.4-bin
checking for references to /build in /nix/store/sbklb7hf1f9sjpv2xaxnxr8cf02fxy7k-kube-prompt-1.0.4-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/sbklb7hf1f9sjpv2xaxnxr8cf02fxy7k-kube-prompt-1.0.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kube-prompt

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sfcfjgr654g01h9r7yyff28i23fs2h0p-kube-prompt-1.0.4-bin
shrinking /nix/store/sfcfjgr654g01h9r7yyff28i23fs2h0p-kube-prompt-1.0.4-bin/bin/kube-prompt
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sfcfjgr654g01h9r7yyff28i23fs2h0p-kube-prompt-1.0.4-bin/bin
patching script interpreter paths in /nix/store/sfcfjgr654g01h9r7yyff28i23fs2h0p-kube-prompt-1.0.4-bin
checking for references to /build in /nix/store/sfcfjgr654g01h9r7yyff28i23fs2h0p-kube-prompt-1.0.4-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/sfcfjgr654g01h9r7yyff28i23fs2h0p-kube-prompt-1.0.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: kube-prompt

Partial log (click to expand)

find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
find: '/nix/store/hm77ch3p7544g076rnbvyvjy3jdajibq-kube-prompt-1.0.4': No such file or directory
/nix/store/0233z0kj963gp6cafibnsb5f3rc4cib0-kube-prompt-1.0.4-bin

@nlewo
Copy link
Member

nlewo commented Oct 23, 2018

Thanks!

@nlewo nlewo merged commit 1a840f6 into NixOS:master Oct 23, 2018
@vdemeester vdemeester deleted the init-kube-prompt branch October 23, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vdemeester @nlewo @GrahamcOfBorg @Mic92