Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfs-utils: add python3 to buildInputs #48611

Merged
merged 1 commit into from Oct 21, 2018
Merged

nfs-utils: add python3 to buildInputs #48611

merged 1 commit into from Oct 21, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 17, 2018 •
edited

This will rewrite the shebang of nfsiostat.

Motivation for this change

Fixes #48599

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
nfs-utils: add python3 to buildInputs
8153f7b 
This will rewrite the shebang of `nfsiostat`.
@FRidh FRidh mentioned this pull request Oct 17, 2018
Closed
@FRidh
Copy link
Member Author

FRidh commented Oct 17, 2018

Closure size increases from 143 MB to 208 MB.

@FRidh FRidh requested a review from vcunat October 17, 2018 08:26
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nfs-utils

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nfs-utils

Partial log (click to expand)

shrinking /nix/store/cwa96n59nfllry5ir667z8ng20jdr36d-nfs-utils-2.3.3-lib/lib/libnfsidmap.so.1.0.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cwa96n59nfllry5ir667z8ng20jdr36d-nfs-utils-2.3.3-lib/lib
patching script interpreter paths in /nix/store/cwa96n59nfllry5ir667z8ng20jdr36d-nfs-utils-2.3.3-lib
checking for references to /build in /nix/store/cwa96n59nfllry5ir667z8ng20jdr36d-nfs-utils-2.3.3-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/4lgza17i5zgjb9gw9zr1jg9ajvw38g9m-nfs-utils-2.3.3-man
gzipping man pages under /nix/store/4lgza17i5zgjb9gw9zr1jg9ajvw38g9m-nfs-utils-2.3.3-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/4lgza17i5zgjb9gw9zr1jg9ajvw38g9m-nfs-utils-2.3.3-man
checking for references to /build in /nix/store/4lgza17i5zgjb9gw9zr1jg9ajvw38g9m-nfs-utils-2.3.3-man...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nfs-utils

Partial log (click to expand)

shrinking /nix/store/xjskscy69ljk7kjsji4lraa60yxr7cng-nfs-utils-2.3.3-lib/lib/libnfsidmap.so.1.0.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xjskscy69ljk7kjsji4lraa60yxr7cng-nfs-utils-2.3.3-lib/lib
patching script interpreter paths in /nix/store/xjskscy69ljk7kjsji4lraa60yxr7cng-nfs-utils-2.3.3-lib
checking for references to /build in /nix/store/xjskscy69ljk7kjsji4lraa60yxr7cng-nfs-utils-2.3.3-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/ix47f7rvwib61dc6rnk384kznm78ljf3-nfs-utils-2.3.3-man
gzipping man pages under /nix/store/ix47f7rvwib61dc6rnk384kznm78ljf3-nfs-utils-2.3.3-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ix47f7rvwib61dc6rnk384kznm78ljf3-nfs-utils-2.3.3-man
checking for references to /build in /nix/store/ix47f7rvwib61dc6rnk384kznm78ljf3-nfs-utils-2.3.3-man...

@xeji
Copy link
Contributor

xeji commented Oct 17, 2018

@GrahamcOfBorg test nfs4

@xeji
Copy link
Contributor

xeji commented Oct 17, 2018

@GrahamcOfBorg test nfs3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nfs4

Partial log (click to expand)

syncing
client2: running command: sync
client2: exit status 0
test script finished in 500.34s
cleaning up
killing client2 (pid 654)
killing server (pid 750)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/0wb10a4ipjbqd2q3qj3m9iqmnhnk4c1p-vm-test-run-nfs

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nfs3

Partial log (click to expand)

syncing
client2: running command: sync
client2: exit status 0
test script finished in 671.33s
cleaning up
killing client2 (pid 654)
killing server (pid 775)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/dabg18di138m9k8lrb8y692yij0ccqag-vm-test-run-nfs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nfs4

Partial log (click to expand)

syncing
client2: running command: sync
client2: exit status 0
test script finished in 370.29s
cleaning up
killing client2 (pid 625)
killing server (pid 725)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/r1izx8d0ym5iddylpqwbarlysbbnp970-vm-test-run-nfs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nfs3

Partial log (click to expand)

syncing
client2: running command: sync
client2: exit status 0
test script finished in 1017.86s
cleaning up
killing server (pid 702)
killing client2 (pid 630)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/91n5byx91xph1i1jszqxngbq6hrkvxi4-vm-test-run-nfs

@FRidh FRidh merged commit 7eb8a04 into NixOS:master Oct 21, 2018
@FRidh FRidh mentioned this pull request Nov 1, 2018
Closed
9 tasks
@FRidh FRidh deleted the nfsutils branch November 1, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @GrahamcOfBorg @xeji