Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxml2: support python3 #48609

Merged
merged 2 commits into from Oct 17, 2018
Merged

libxml2: support python3 #48609

merged 2 commits into from Oct 17, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 17, 2018 •
edited

Motivation for this change

Fixes #48490

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Oct 17, 2018

@GrahamcOfBorg eval

@FRidh
Copy link
Member Author

FRidh commented Oct 17, 2018

Odd, @GrahamcOfBorg says it doesn't eval, but it does locally (and I can build the package flexget).

@FRidh FRidh merged commit d0d04c2 into NixOS:staging Oct 17, 2018
@FRidh FRidh deleted the libxml2 branch October 17, 2018 11:53
@jtojnar jtojnar mentioned this pull request Oct 30, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh