Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ns-2: init at 2.35 #47524

Closed
wants to merge 4 commits into from
Closed

ns-2: init at 2.35 #47524

wants to merge 4 commits into from

Conversation

pschuprikov
Copy link
Contributor

Motivation for this change

NS2 is a previous incarnation of the NS3 network simulator that is already in nixpkgs. NS3 is a next-to-complete rewrite of NS2, and while it is considered superior, feature parity is yet to achieve. For that reason, NS2 is still actively used in the research community.

I haven't placed NS2 next to NS3 in development/libraries/... since NS2 is mainly used through the ns executable, as opposed to NS3 that is primarily a set of libraries to link against.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

Is this project still maintained? Last release is 2011 and it needs 3 patches to compile.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

cc @teto

@pschuprikov
Copy link
Contributor Author

@Mic92 I believe it is not maintained. I've been using it myself and thought why not to tidy it up and package. If it is not a good fit for nixpkgs, I am totally OK with closing the PR :-)

@teto
Copy link
Member

teto commented Sep 29, 2018

Not super excited by getting ns2 into nixpkgs as it might have more models but the "low" quality of the models might have been the motivation for ns3 in the first place (I have used ns2 just once and that one protocol model was horrible, it might just be that model though). @pschuprikov it might be better in an NUR overlay ?

@pschuprikov
Copy link
Contributor Author

@teto Thanks for the suggestion. Being honest I haven't heard of NUR before, but it sounds like a better option indeed. I'm closing the PR then.

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

@pschuprikov thanks, NUR is a great option for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pschuprikov @Mic92 @teto @GrahamcOfBorg