Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upower: 0.99.7 -> 0.99.8 #47527

Closed
wants to merge 1 commit into from
Closed

upower: 0.99.7 -> 0.99.8 #47527

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 29, 2018

Bump.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
upower: 0.99.7 -> 0.99.8
8d0e94f 
(cherry picked from commit 67ac9c649ffc036c49006191c64555eae2e6012f)
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: upower

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: upower

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8
shrinking /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/bin/upower
shrinking /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/libexec/upowerd
shrinking /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/lib/libupower-glib.so.3.0.1
gzipping man pages under /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/lib  /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/libexec  /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8/bin
patching script interpreter paths in /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8
checking for references to /build in /nix/store/3jy49h6q8j6z9ypjnmjlb40qv4vss0p8-upower-0.99.8...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: upower

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8
shrinking /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/libexec/upowerd
shrinking /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/bin/upower
shrinking /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/lib/libupower-glib.so.3.0.1
gzipping man pages under /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/lib  /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/libexec  /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8/bin
patching script interpreter paths in /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8
checking for references to /build in /nix/store/g4hvjl8brq7nn20wiagxvj4y0f8p4dhi-upower-0.99.8...

jtojnar
jtojnar reviewed Sep 29, 2018
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ask upstream to upload the tarball to the server? GitLab URLs are not predictable.

@dtzWill
Copy link
Member Author

dtzWill commented Sep 29, 2018

Oh, right! Looking into where we could ask such a thing I found this on the mailing list: https://lists.freedesktop.org/archives/devkit-devel/2018-June/001829.html

Also I think this uses a specific tarball artifact that was uploaded for the tag, not the auto-generated tarballs gitlab can produce (which I believe is what has been problematic in the past as the generation can produce differences sometimes). Please take a look at the thread and/or check that this seems about right-- agreed we want a stable URL here :).

@jtojnar
Copy link
Contributor

jtojnar commented Sep 29, 2018 •
edited

The autogenerated tarballs are just git snapshots, these artefacts are most likely dist tarballs

@dtzWill
Copy link
Member Author

dtzWill commented Oct 6, 2018

So we're agreeing this is good to go? Or...? :)

@jtojnar
Copy link
Contributor

jtojnar commented Oct 6, 2018

I would rather if we could use predictable tarball location, opened an issue upstream: https://gitlab.freedesktop.org/upower/upower/issues/80

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2018

On top of it, 0.99.8 has regressions with accessing udev events and keyboard backlight support.

One alternative (taken from Arch) would be to fetchgit and fetchpatch from the repo clone at https://cgit.freedesktop.org/upower/

@dtzWill
Copy link
Member Author

dtzWill commented Oct 29, 2018

Closing in favor of #49395 (which I believe includes fixes for the mentioned regressions).

@dtzWill dtzWill closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @jtojnar @c0bw3b